Issues.00054 - lordmundi/wikidoctest GitHub Wiki

00054: cev_plume_drive.tcl and cev_plume_init.tcl should not have hard-coded dependency on cev_plume_array.tcl

« 00053 | Issues | 00055 »

Summary: cev_plume_drive.tcl and cev_plume_init.tcl should not have hard-coded dependency on cev_plume_array.tcl

Created: 2007–08–29 13:26

Status: Released

Category: Request

From: smermel

Version: 1.1

Released_In: 2.0

Description:
plume_drive and plumie_init both read in the array using syntax like

if { [catch { source "$env(DOUG_HOME)/gui/cev_plume_array.tcl" } results] != 0 }

{

puts "ERROR sourcing $env(DOUG_HOME)/gui/cev_plume_array.tcl: ${results}"

exit −1

}

I'd prefer it to say something like

if { [catch { source "$env(PLUME_ARRAY}" } results] != 0 }

{

puts "ERROR sourcing $env{PLUME_ARRAY}: ${results}"

exit −1

}

This way, if I change the plume array (as I had to, this once, though it should be much more stable now), I don't have to change the other two files.

Comments

frankie November 06, 2007, at 03:31 PM: Fixed as suggested.

« 00053 | Issues | 00055 »

Associated Commits

| commit | 55cdf0c6f1012deb9789d1de8dba839c948d7b2f link 6 | || | Author: | Frankie Graffagnino | | Date: | Tue Nov 6 15:32:57 2007 -0600 | | Message: | [@Issue 00054: removed hard coding filename and moved to env variable @] |

Affected Files:

.doug_cshrc             |  1 +
 gui/cev_plume_drive.tcl | 11 ++++++++&plusmn;-
 gui/cev_plume_init.tcl  | 11 ++++++++&plusmn;-
 3 files changed, 19 insertions(+), 4 deletions(-)