query as class - STEMLab/geotools GitHub Wiki

• Motivation: Why bother

• Tracker: https://osgeo-org.atlassian.net/browse/GEOT-3055

• Tagline: Query vs DefaultQuery

Description

Query is an interface with a single implementation ... DefaultQuery. As such it is not earning its keep and represents needless complexity.

To simplify turn Query into a class and pull up method implementations from DefaultQuery:

class Query {
  ...
  public String getHandle() {
    return this.handle;
  }
  ...
}
class DefaultQuery extends Query {
  // empty
}

Patch is available on the attached bug report; it also updates the query Java docs (something else that can be improved without a proposal).

Status

This proposal is ready; there is a patch that can be applied.

We are done and the patch has been applied to 2.7.x!

• Andrea Aime +1
• Ben Caradoc-Davies +1
• Christian Mueller +1
• Ian Turton +0
• Justin Deoliveira
• Jody Garnett +1
• Michael Bedward +1
• Simone Giannecchini +1

Tasks

This section is used to make sure your proposal is complete (did you remember documentation?) and has enough paid or volunteer time lined up to be a success

        | :white_check_mark: | :no_entry: | :warning:               | :negative_squared_cross_mark: |

------------|--------------------|------------|-------------------------|-------------------------------| no progress | done | impeded | lack mandate/funds/time | volunteer needed |

1. Apply patch from https://osgeo-org.atlassian.net/browse/GEOT-3055
2. Update example code