Peer Review Question Set - SENG-350-2024-fall/Team3 GitHub Wiki

Question Set Name: Peer Reviewing Design Document and Code Architecture
Purpose: Use this question set to assess the choice of design, structure, and team practices as seen in the AD, and their ability to capture stakeholders’ concerns
Stakeholders and Concerns: Developer, who specify and then use the frameworks, languages, and coding practices. Analysts who can confirm or refute that the chosen frameworks and modeling approaches are feasible for the project

Questions:	Respondents	Expected Answers	Criticality
State your stakeholder role. List the set of concerns you have that pertain to the architecture whose AD is being reviewed	All Stakeholders	Stakeholders should clearly see their roles and concerns in the AD. All concerns must link to a stakeholder, with missing ones noted. The architect must justify the stakeholder identification process, and respondents should note the AD's ease of use.	Miss-ing stakehold-ers or missing concerns are the most criti-cal.
Show where in the AD the generic stake-holders and concerns required by the framework in use (if any) have been listed and addressed	Developer	Respondents should be able to point to the parts of their AD that address the stakeholders concerns	Any unidentified stakeholder concerns are critical
Are all concerns addressed either by one or more models or by one or more correspondences among models	All Stakeholders	Respondents should be prepared to point out where in the AD their answers are supported	Concerns that aren't addressed in the AD are critical
Are the trade-offs between competing architectural decisions documented?	Developers	Trade offs should be listed and explained why each was chosen	architectural decision that aren't listed are critical