Feedback - smolgeorgie/the-startup-responsive-interactieve-website GitHub Wiki

📅 Feedback 25/1/2024

For our feedback, we visited the Funda building again to meet with our client(s). We went through every repository and code, and reviewed our page. The feedback was overall very positive and they didn't really look at how much content you had, but how you used everything.

Feedback Funda

opera_FhlUlJnz4w

My feedback

My feedback was to add a 'real estate' section, because this was mandatory for the assignment and of greater importance. For the desktop layout, I had to change my image stacks from a flexbox to a grid, because it will make it more responsive and cleaner, yet also accessible. I had some weird hover states and my javascript was loaded in onWindow, which I couldn't use for accessibility reasons. It makes the page load in way slower.

General feedback

The general feedback they gave was to start with more structure in html, have everything in the right order, and from then to build the css. This creates a better overview on what you're doing. I could relate because I created my css for every section I wrote in html. This didn't work because I got stuck multiple times and broke a lot of css on the way to the finished product.