20200218_jeffrey - silenceuncrio/diary GitHub Wiki

0900

review


昨天有發一條 issue 給自己

m350 可以複製出問題

先在 m350 上解決


目前用 workaround 的方式

不然讓底層做修改的話可能會有其它副作用

修改方式如下 - 順便也寫了原因

diff --git a/proscend/prosrc/webcgi/connmgr.c b/proscend/prosrc/webcgi/connmgr.c
index 2878bb0..c440c87 100644
--- a/proscend/prosrc/webcgi/connmgr.c
+++ b/proscend/prosrc/webcgi/connmgr.c
@@ -186,6 +186,15 @@ static void _chg_wproto_apply()
         jweb.out.json.fail("ICOS_Apply fail");
     }

+    /*
+    ** workaround
+    ** icos module connmgr use ICOS_msg_sendto_opt() to handle this apply
+    ** so the real handler of this apply is the message receiver
+    ** we do not know how soon the message arrive and the receiver done its job
+    ** so sleep here, let the message fly a while...
+    */
+    sleep(3);
+
     jweb.out.json.ok();
 }

(END)

多測一下

發現 sleep(3) 還不夠

改成 sleep(5) 再多做一下測試


注意

這樣的測試很容易複製出 web session 機制的問題

Work As 切換個幾次就會跳出 login 畫面

不過 一碼歸一碼

問題一個一個來解決


m350[develop] - [workaround]sleep a while in connmgr.cgi?act=chg_wproto_apply

commit 00083af194e5b6dd42dd079a6888be30a7f36a68
Refs: [develop], {origin/develop}
Author: jeffrey <[email protected]>
Date:   Tue Feb 18 10:30:35 2020 +0800

    [workaround]sleep a while in connmgr.cgi?act=chg_wproto_apply

    icos module connmgr use ICOS_msg_sendto_opt() to handle this apply
    so the real handler of this apply is the message receiver
    we do not know how soon the message arrive and the receiver done its job
    so sleep here, let the message fly a while...

 proscend/prosrc/webcgi/connmgr.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

急件 - 麻煩把 M330 的 GPS config sync code M300 (develop) branc

ear Aaron and Jeffrey,

麻煩把 M330 的 GPS config sync code M300 (develop) branch. 我底層已經 sync code 可是忘記通知上層sync code, 真是糟糕. sync 完通知我測試一下.

相關 mantis issue

1035

M300 和 m330 各準備一台

VMware 切回 jbox

1135

先做 LTE > GPS 這個頁面

從 m330 同步過來

搭配測試

該同步的 CGI 也不要漏掉

build 個完整的 image 再來做測試

1300

測試 PASS 上 code

M300[develop] - sync the 'LTE > GPS' web page from m330

commit 97140c782d7aeeac2c6f1bc2f83bf0357435e7bb
Refs: [develop], {origin/develop}
Author: jeffrey <[email protected]>
Date:   Tue Feb 18 13:03:48 2020 +0800

    sync the 'LTE > GPS' web page from m330

 proscend/prosrc/webcgi/lte.c                       |  26 +++
 proscend/prosrc/www/Makefile                       |   1 -
 proscend/prosrc/www/app/feature/lteGps.html        | 205 +++++++++++++++++++++
 proscend/prosrc/www/app/feature/lteGps.js          |  24 ++-
 proscend/prosrc/www/app/locale-en.json             |  40 ++--
 proscend/prosrc/www/app/locale-fr.json             |  40 ++--
 proscend/prosrc/www/app/locale-zh-tw.json          |  40 ++--
 .../prosrc/www/src/app/feature/lteGps.html.src     | 137 --------------
 8 files changed, 325 insertions(+), 188 deletions(-)

再來是從 m330 把 LTE > GPS Track porting 到 M300 來


注意

意外的發現 LTE > GPS Track 開新分頁的方式

IE 上就不會有不能縮放視窗的問題

我想可以用相同的方式來取代目前開啟 online manual 的方式

這可以解決 mantis issue - M300 - 0000914: online manual opened via ie without the ability to adjust window screen size


注意到 online manual 也要從 m300 來同步

直接再 build 一次 image


注意

注意到早上從 m330 sync 過來的 LTE > GPS web page

相對應的 online manual 也需要 update


注意

WAN > Ethernet - Work As 欄位的 workaround 記得也要套到 M300 來


1440

LTE > GPS Track 是從 m330 porting 過來了


注意

但因為 M300 與 m330 在 www 資料夾下 Makefile 的差異

導致 M300 menu 上的 LTE > GPS Track 連結

有奇怪的 query string 如下

M300 - LTE > GPS Track - strange query string withing hyper link image

但不影響功能使用 - 先不要去改

一碼歸一碼


上 code

M300[develop] - porting 'LTE > GPS Track' web page from m330

commit 9149d86fe728956552487ca27436028cb736b8ec
Refs: [develop], {origin/develop}
Author: jeffrey <[email protected]>
Date:   Tue Feb 18 14:49:20 2020 +0800

    porting 'LTE > GPS Track' web page from m330
    - also the online manual

 proscend/prosrc/webcgi/lte.c                       |   2 +-
 proscend/prosrc/www/Makefile                       |   1 +
 proscend/prosrc/www/app/feature/lteGpsTrack.html   |  31 ++
 proscend/prosrc/www/app/feature/lteGpsTrack.js     | 169 ++++++
 proscend/prosrc/www/app/locale-en.json             |   6 +
 proscend/prosrc/www/app/locale-fr.json             |   6 +
 proscend/prosrc/www/app/locale-zh-tw.json          |   6 +
 .../angular-leaflet-directive.min.js               |  40 ++
 .../leaflet.polylineDecorator.js                   | 601 +++++++++++++++++++++
 proscend/prosrc/www/libs/leaflet/leaflet.css       | 479 ++++++++++++++++
 proscend/prosrc/www/libs/leaflet/leaflet.js        |   9 +
 proscend/prosrc/www/src/lteGpsTrack_blank.html.src |  80 +++
 proscend/prosrc/www/src/manual.html.src            |   4 +
 .../prosrc/www/src/manual/lte_gps_track.h.html     |  11 +
 proscend/prosrc/www/src/manual/sidebar.h.html      |   3 +
 proscend/prosrc/www/src/menu.html.src              |   6 +
 16 files changed, 1453 insertions(+), 1 deletion(-)

1450

review 一下 注意

LTE > GPS 的 online manual 也要從 m330 sync 過來

M300[develop] - sync the online manual of 'LTE > GPS' from m330

commit 95386a7246f8a646490fcc21b1e2f1ef32576e69
Refs: [develop], {origin/develop}
Author: jeffrey <[email protected]>
Date:   Tue Feb 18 14:57:32 2020 +0800

    sync the online manual of 'LTE > GPS' from m330

 proscend/prosrc/www/src/manual/lte_gps.h.html | 37 +++++++++++++++++++--------
 1 file changed, 27 insertions(+), 10 deletions(-)

1500

WAN > Ethernet - Work As 欄位的 workaround 記得也要套到 M300 來

不過 M300 竟然複製不出問題來 - 沒問題就不要 workaround 了


跟 ariel 討論了一下

ariel 會找時間去 review 一下底層的 code

我就先不要用 workaround 的方式去套其他平台了

不過可以 update 一下目前發現的線索

目前 issue 0000918: after apply ok with 'Work As' field changed, sometimes the value will be kept the old one update 情報之後已轉 assign 給 ariel

1530

M300 gps 相關的 sync 已完成

1540

就用今天的發現來解 mantis issue - M300 - 0000914: online manual opened via ie without the ability to adjust window screen size


解完發現另外的 bug - 並不是這個解法引起的

ie - online manual - color icons disappear image


先上 code - 這解法可以套到全平台

M300[develop] - use 'target' attribute to specify opening the online manual in a new tab

  • then ie browser has no problem to adjust window screen size
commit 573f451012d74e2cd50653d5764879ab1492772d
Refs: [develop], {origin/develop}
Author: jeffrey <[email protected]>
Date:   Tue Feb 18 16:01:38 2020 +0800

    use 'target' attribute to specify opening the online manual in a new tab
    - then ie browser has no problem to adjust window screen size

 proscend/prosrc/www/app/app.controller.js                 | 8 --------
 proscend/prosrc/www/brand_advice/src/brand/top.html.src   | 3 ++-
 proscend/prosrc/www/brand_ctcu/src/brand/top.html.src     | 3 ++-
 proscend/prosrc/www/brand_cxr/src/brand/top.html.src      | 3 ++-
 proscend/prosrc/www/brand_digicomm/src/brand/top.html.src | 3 ++-
 proscend/prosrc/www/brand_hytec/src/brand/top.html.src    | 3 ++-
 proscend/prosrc/www/brand_nobrand/src/brand/top.html.src  | 4 ++--
 proscend/prosrc/www/brand_planet/src/brand/top.html.src   | 3 ++-
 proscend/prosrc/www/brand_xentino/src/brand/top.html.src  | 3 ++-
 9 files changed, 16 insertions(+), 17 deletions(-)

先 update 一下 M300 的 release note - 跟今天的修改相關

  • M300[develop] - sync the 'LTE > GPS' web page from m330
  • M300[develop] - porting 'LTE > GPS Track' web page from m330

release note 是要寫給客戶看的

參考一下 m330 的 release note

Proscend M330 Nobrand  Release Notes:
==========================================
[Version Detail]
1. U-Boot Version:
...
   [New]
    * WIFI AP Tx Power.
    ...
    * GPS config: TCP Push.
    * GPS Track.

M300[develop] - update the release note

  • according to the information from the release note of m330
commit bb53961b282f32ed74faff00069f975f6707f624
Refs: [develop], {origin/develop}
Author: jeffrey <[email protected]>
Date:   Tue Feb 18 16:18:19 2020 +0800

    update the release note
    - according to the information from the release note of m330

    [New]
    * GPS config: TCP Push.
    * GPS Track.

 M30x-ReleaseNotes.txt        | 3 ++-
 M30x-ReleaseNotes_Advice.txt | 3 ++-
 M30x-ReleaseNotes_CTC.txt    | 3 ++-
 M30x-ReleaseNotes_CXR.txt    | 3 ++-
 M30x-ReleaseNotes_Hytec.txt  | 3 ++-
 M30x-ReleaseNotes_Planet.txt | 3 ++-
 6 files changed, 12 insertions(+), 6 deletions(-)

1630

專門為了 web session 的問題發一條 issue 給自己


更新一下 issue - 0000914: online manual opened via ie without the ability to adjust window screen size

提醒自己這個 issue 還有哪些機種等待解決


來解決 M330 好了 - 一樣在 VMware jbox 上工作

m330[develop] - use 'target' attribute to specify opening the online manual in a new tab

  • then ie browser has no problem to adjust window screen size
commit d33f2eb43071e4325ade94280470aa6229ab9cd4
Refs: [develop], {origin/develop}
Author: jeffrey <[email protected]>
Date:   Tue Feb 18 17:17:39 2020 +0800

    use 'target' attribute to specify opening the online manual in a new tab
    - then ie browser has no problem to adjust window screen size

 proscend/prosrc/www/app/app.controller.js                  | 14 --------------
 proscend/prosrc/www/brand_allnet/src/brand/top.html.src    |  4 ++--
 proscend/prosrc/www/brand_ctcu/src/brand/top.html.src      |  4 ++--
 proscend/prosrc/www/brand_hytec/src/brand/top.html.src     |  4 ++--
 .../prosrc/www/brand_hytec_korea/src/brand/top.html.src    |  4 ++--
 proscend/prosrc/www/brand_nobrand/src/brand/top.html.src   |  4 ++--
 proscend/prosrc/www/brand_proscend/src/brand/top.html.src  |  4 ++--
 7 files changed, 12 insertions(+), 26 deletions(-)

繼續 M360P - 切到 VMware jubuntu

M360P[develop] - use 'target' attribute to specify opening the online manual in a new tab

  • then ie browser has no problem to adjust window screen size
commit 5156522990a7641b00d253f48e98c8539d3dc4b4
Refs: [develop], {origin/develop}
Author: jeffrey <[email protected]>
Date:   Tue Feb 18 17:41:31 2020 +0800

    use 'target' attribute to specify opening the online manual in a new tab
    - then ie browser has no problem to adjust window screen size

 proscend/prosrc/www/app/app.controller.js                 | 8 --------
 proscend/prosrc/www/brand_nobrand/src/brand/top.html.src  | 4 ++--
 proscend/prosrc/www/brand_proscend/src/brand/top.html.src | 4 ++--
 3 files changed, 4 insertions(+), 12 deletions(-)

剩 M350


M350 online manual 的 color icons 沒有問題

難道是 m350 有把 font awesome 的字形補齊 ?


m350[develop] - use 'target' attribute to specify opening the online manual in a new tab

  • then ie browser has no problem to adjust window screen size
commit 96e38865610dcc7c1310781415715b08cc4c3540
Refs: [develop], {origin/develop}
Author: jeffrey <[email protected]>
Date:   Tue Feb 18 17:58:39 2020 +0800

    use 'target' attribute to specify opening the online manual in a new tab
    - then ie browser has no problem to adjust window screen size

 proscend/prosrc/www/app/app.controller.js                    | 8 --------
 proscend/prosrc/www/brand_ctcu/src/brand/top.html.src        | 4 ++--
 proscend/prosrc/www/brand_hytec/src/brand/top.html.src       | 4 ++--
 proscend/prosrc/www/brand_hytec_korea/src/brand/top.html.src | 4 ++--
 proscend/prosrc/www/brand_nobrand/src/brand/top.html.src     | 4 ++--
 proscend/prosrc/www/brand_proscend/src/brand/top.html.src    | 4 ++--
 6 files changed, 10 insertions(+), 18 deletions(-)