20190212_jeffrey - silenceuncrio/diary GitHub Wiki

0920

review

1040

今天 M330 make 發生 error

connmgr.c: In function 'chg_internet_led':
connmgr.c:179:33: error: 'WIFI_HEARTBEAT_LED' undeclared (first use in this function)
connmgr.c:179:33: note: each undeclared identifier is reported only once for each function it appears in

重新進入一次開發 M330 用的 docker container

proscend 外層直接敲 make 再 build 一次

進 proscend 目錄

make distclean
make menuconfig
- Products/Vendor = M330/1_WIFI
make

還是一樣的錯誤

connmgr.c: In function 'chg_internet_led':
connmgr.c:179:33: error: 'WIFI_HEARTBEAT_LED' undeclared (first use in this function)
connmgr.c:179:33: note: each undeclared identifier is reported only once for each function it appears in

奇怪的是昨天明明 build 過了

修改 Products/Vendor = M330/0_GENERIC

build 過了

1130

再讓 Products/Vendor = M330/1_WIFI

幫忙排除一下

diff --git a/proscend/prosrc/icos/icoslib/wan_connmgr/connmgr.c b/proscend/prosrc/icos/icoslib/wan_connmgr/connmgr.c
index b1aaa6b..1e73803 100644
--- a/proscend/prosrc/icos/icoslib/wan_connmgr/connmgr.c
+++ b/proscend/prosrc/icos/icoslib/wan_connmgr/connmgr.c
@@ -176,7 +176,7 @@ void chg_internet_led(int led_status)
             led_blink_fast(LED_INTERNET);
         }
 #ifdef PROSRC_WIFI_APSTA
-        else if (led_status ==  WIFI_HEARTBEAT_LED)
+        else if (led_status ==  WIFI_HEARBEAT_LED)
         {
             led_heartbeat(LED_INTERNET);
         }

搞定上 code

發現我拼錯字了

commit 208498b33769ed62e906028d3529c87f6d453371
Author: jeffrey <[email protected]>
Date:   Tue Feb 12 11:31:44 2019 +0800

    fix typo again

diff --git a/proscend/prosrc/icos/icoslib/wan_connmgr/connmgr.c b/proscend/prosrc/icos/icoslib/wan_connmgr/connmgr.c
index 1e73803..1b1d424 100644
--- a/proscend/prosrc/icos/icoslib/wan_connmgr/connmgr.c
+++ b/proscend/prosrc/icos/icoslib/wan_connmgr/connmgr.c
@@ -17,7 +17,7 @@
 #define CONN_LOGMAX   131072
 #define CPRT(FMT, ARG...) IPC_filelog(CONN_LOG, CONN_LOGMAX, __FUNCTION__, __LINE__, FMT, ##ARG)
 #ifdef PROSRC_WIFI_APSTA
-#define WIFI_HEARBEAT_LED      666
+#define WIFI_HEARTBEAT_LED     666
 #endif
 /***************************************************************************
  *     Global variables
@@ -176,7 +176,7 @@ void chg_internet_led(int led_status)
             led_blink_fast(LED_INTERNET);
         }
 #ifdef PROSRC_WIFI_APSTA
-        else if (led_status ==  WIFI_HEARBEAT_LED)
+        else if (led_status ==  WIFI_HEARTBEAT_LED)
         {
             led_heartbeat(LED_INTERNET);
         }
@@ -247,7 +247,7 @@ static void check_wan_status()
     //else if ((G_wan_led.fun_led_val==WiFi_AP) && (monitor_wan.wifi_ap_connected>0))
     else if (monitor_wan.wifi_ap_connected>0)
     {
-        led_status = WIFI_HEARBEAT_LED;
+        led_status = WIFI_HEARTBEAT_LED;
     }
 #endif
     else

1330

commit 811141f01233acc15d51a8e1a52b565cdf6fce02
Author: jeffrey <[email protected]>
Date:   Tue Feb 12 13:31:55 2019 +0800

    refactor and improve the login flow

 proscend/prosrc/www/app/feature/login.js | 184 ++++++++++++++++++-------------
 1 file changed, 106 insertions(+), 78 deletions(-)

1350

commit 7432fcd8a9cb340562ea77817f725aab08bcfe70
Author: jeffrey <[email protected]>
Date:   Tue Feb 12 13:51:57 2019 +0800

    refactor and improve the logout flow

 proscend/prosrc/www/app/feature/logout.js | 74 +++++++++++++++++--------------
 1 file changed, 40 insertions(+), 34 deletions(-)

1525

commit 3446b0f63070c7714e763d7f17782952cd02da41
Author: jeffrey <[email protected]>
Date:   Tue Feb 12 15:25:22 2019 +0800

    sleep 1 second before restart web daemon
    - so the web daemon restart after the cgi response

 proscend/prosrc/icos/icoslib/web/webcfg.c | 1 +
 1 file changed, 1 insertion(+)

1540

commit 7e4898cf69e2848f162b5c6dd78e4e0359004efe
Refs: [feature/proscend-porting], {origin/feature/proscend-porting}
Author: jeffrey <[email protected]>
Date:   Tue Feb 12 15:40:28 2019 +0800

    give the password input fields a init value or they will be undefined

 proscend/prosrc/www/app/feature/administration.js | 4 ++++
 1 file changed, 4 insertions(+)

上述這兩個 commit 也可以套用到 M300 與 M360 去

同時也能解決 M300 客戶 HYTEC 近期所反應的問題

0000416: (Hytec) SessionTTL

Changing SessionTTL(WEBGUI automatic log out time), clicking “Apply” then”Apply Fail” comes.
Setup seems OK.（sometimes Apply OK）

1735

commit e2b3c251b25702af6d934d332d830c86fdb37bc7
Refs: [feature/proscend-porting], {origin/feature/proscend-porting}
Author: jeffrey <[email protected]>
Date:   Tue Feb 12 17:33:05 2019 +0800

    remove the duplicate sed-replacement

 proscend/prosrc/www/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)