Stammtisch 2018_07_31 - shogun-toolbox/shogun GitHub Wiki

Notekeeper: Fernando.

• GSoC last sprint!

1. Importance of blog posts and other GSoC logistics (see e-mail from Heiko for details).
2. Coding period ends this week, so it is time to take care of the peer review (really useful!) and final materials.

• CWeightedDegreeStringKernel's constructor with EWDKernType parameter and whether there should be a factory for it.

1. Triggered by Wuwei.
2. The issue is about set_wd_weights_by_type being called from this constructor, but for instance not from the default constructor as this method depends on a couple of attributes.
3. Action point to investigate: does this class need the type attribute at all? It seems from the assert in the set_wd_weights_by_type method that it only works for a particular type.
4. Action point to investigate: when should this method be called? On constructor? Probably not because it depends on the degree attribute. On the init accepting features? Maybe, but it may incur overhead. On set to the degree attribute?