Problems Fixes - sebascm/taxi-booking GitHub Wiki
Fixes
In this page I will track the errors and the fixes needed to solve them
Compile errors
- Javax.inject dependency needed
- Added to pom
- Warning with deprecated class in DataMapper
- Couldn't fix the warning. I've updated the dependencies associated to the class deprecated but didn't work. I've put a SuppressWarning
POM enhancements
-
Refactor the 6 POMs. I will use this Maven Plugin that it helps to sort the POMs. You can specify the order of elements.
- All worked
-
Update the dependencies and clean unnecessary ones (if it is needed). Research about some dependencies is needed in order to update them.
- All plugins were updated to latest stable version but spring had to be updated to latest 1.5.X instead 2.X because it caused compilation failure.
- Somehow this project fails when you try to use Maven Enforcer to put the minimum version of Maven (the way it has to be)ยท To solve it, it's necessary to use tag. PR related to this.
-
Add checkstyle and fix the code style.
- Due to the huge inconsistent code style of this project, I had to customize the Google code style to avoid spend more time.
-
Add spotbugs and fix the bugs.
- I had to use a filter to exclude all the bugs. I've tried to use the annotation @SuppressFBWarnings but it didn't work.
-
Maven phases were not executing all the added plugin goals.
- There wasn't a plugins tag, only pluginManagement, which caused not executing any of the plugins (sortpom, checkstyle, spotbugs and even enforcer)
-
Figure it out how to run the project
- Finally, I could resolve the problem with Jackson plugin. It was a dependency problem. Thanks you so much to the first answer.
Docker
- Dockerize the app
- I had to dockerize the config module because the main one documentation is missing.
- To create the jar, it must be executed with mvn package spring-boot:repackage