Reviewing Pull Requests - public-transport/transitous GitHub Wiki

Before merging

  • CI passes
  • Only files in feeds/ are modified or it's certain that the changes don't do malicious things over network. This is important as would have consequences for Spline (where our stuff is hosted for free), since this is a university network.

After merging

  • The pipeline on https://routing-import.spline.de passes. If the import fails with "No such file or directory", probably the download / processing of one feed failed, and there is no cache to use. This only happens on the initial import, for refreshes there is always a cached fallback to use. If the pipeline fails, please hotfix or revert the changes, as otherwise it blocks updating data for all feeds.