WG HUSKY Meeting 20230704 - project-husky/project-husky.github.io GitHub Wiki

Meeting Workgroup Husky (July 4th, 2023, 08:00-08:30 CET)

Access:

Google Meet

Presence:

  • Roeland Luykx (RALY GmbH)
  • Nikola Tanjga (ELGA)
  • Martin Smock (eHealth Suisse)
  • Dmytro Rud (IPF Developer, adesso)

Excused:

  • Carole Kaiser (eHealth Suisse)
  • Tanja Reiterer (et-innovations)
  • Anna Jungwirth (et-innovations)
  • Oliver Egger (ahdis ag)
  • Quentin Ligier (HUG/ahdis ag)

Agenda

  • Source Code Repo / Processes
  • Work in Progress
  • API Refactoring
  • Varia

Discussion

Source Code Repo / Processes

During last meeting, nikola proposed to have a look at the elga terminologit informations: Contributing Code of conduct

Based on some point out of the above links, the proposal of the process would be:

  • It is planned to protect the master branch. This branch should be used for building releases.
  • A new branch called "develop" should be introduced. This branch will also be protected and PR's can only be merged by people making reviews of the changes. should not be the same as developer.
  • Contributing to the source code should always start with adding an issue with clear understandable requirements or bug descriptions.
  • Create your own branch from the current development branch with a name including the issue number.
  • Once you will be finished, you can make a Pull Request (PR) with a speaking merge title and the link to the issue.
  • Assign one or more reviewer
  • Once all reviews are done and ok, the PR will be merged

Work in Progress

What is actually in work?

  • Fix of integration tests [INFO] Results: [INFO] [ERROR] Failures: [ERROR] SimplePpfClientAtnaAuditTest.testSendPpq1AddDeletePolicy:293 expected: <true> but was: <false> [ERROR] SimplePpqClientAtnaAuditTest.testSendPpq2:117 expected: not <null> [ERROR] SimplePpqClientTest.testQueryHcpPolicyWithPolicy:172 expected: not <null> [ERROR] SimplePpqClientTest.testQueryPolicyWithUnknownPid:98 expected: not <null> [ERROR] SimplePpqClientTest.testQueryPolicyWithUnknownPolicySetId:128 expected: not <null> [ERROR] CHPixV3FeedTest.feedTest:200 expected: <true> but was: <false> [ERROR] CHProvideAndRegisterDocumentSetTest.submitJSONDocumentTest:252 expected: <true> but was: <false> [ERROR] CHRegistryStoredQueryTest.queryFindDocuments:190 expected: <true> but was: <false> [ERROR] ConvenienceCommunicationAtnaAuditTest.queryGetDocumentsMetadataOfCdaWithAuditMessage:142->checkAuditLogging:274 expected: <true> but was: <false> [ERROR] ConvenienceCommunicationAtnaAuditTest.retrieveDocumentCdaTest:201->checkAuditLogging:274 expected: <true> but was: <false> [ERROR] ConvenienceCommunicationAtnaAuditTest.submitPdfDocTest:248 expected: <true> but was: <false> [ERROR] ConvenienceCommunicationQueryDocumentsTest.queryFindDocumentsEmptyResponseTest:149 expected: <true> but was: <false> [ERROR] ConvenienceCommunicationQueryDocumentsTest.queryFindDocumentsMetadataOfCda:359 expected: <true> but was: <false> [ERROR] ConvenienceCommunicationQueryDocumentsTest.queryFindDocumentsMetadataOfPdf:217 expected: <true> but was: <false> [ERROR] ConvenienceCommunicationSubmitDocumentTest.submitPdfDocTest:142 expected: <true> but was: <false> [ERROR] ConvenienceMasterPatientIndexV3AtnaAuditTest.queryPatientDemographicsWithAtnaAuditMessageTest:127->checkAuditLogging:239 expected: <true> but was: <false> [ERROR] ConvenienceMasterPatientIndexV3AtnaAuditTest.queryPatientIdTest:214->checkAuditLogging:239 expected: <true> but was: <false> [ERROR] ConvenienceMasterPatientIndexV3AtnaAuditTest.updatePatientTest:178->checkAuditLogging:239 expected: <true> but was: <false> [ERROR] PdqV3QueryTest.ITI47ConsumerQueryPatientPatientIdFoundTest:270 expected: <true> but was: <false> [ERROR] PdqV3QueryTest.ITI47ConsumerQueryPatientPatientIdMultipleCriteria:347 expected: <true> but was: <false> [ERROR] PdqV3QueryTest.ITI47ConsumerQueryPatientPatientIdNotFoundTest:234 expected: <true> but was: <false> [ERROR] PdqV3QueryTest.ITI47ConsumerQueryPatientPatientIdSearchByName:305 expected: <true> but was: <false> [ERROR] Errors: [ERROR] SimplePpfClientTest.setup:163->requestIdpAssertion:192 » ClientSend javax.net.ssl.SSLHandshakeException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target [ERROR] SimplePpfClientTest.setup:163->requestIdpAssertion:192 » ClientSend javax.net.ssl.SSLHandshakeException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target [ERROR] SimplePpfClientTest.setup:163->requestIdpAssertion:192 » ClientSend javax.net.ssl.SSLHandshakeException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target [ERROR] SimplePpfClientTest.setup:163->requestIdpAssertion:192 » ClientSend javax.net.ssl.SSLHandshakeException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target [ERROR] ConvenienceCommunicationSubmitDocumentTest.replaceCdaDocTest:237 » WebService Could not receive Message. [ERROR] ConvenienceCommunicationSubmitDocumentTest.submitCdaDocTest:170 » WebService Could not receive Message. [ERROR] ConvenienceCommunicationSubmitDocumentTest.submitDocumentWrongMetadataTest:203 » WebService Could not receive Message. [INFO] [ERROR] Tests run: 64, Failures: 22, Errors: 7, Skipped: 0

  • Fix of certificates for reference environment

  • EMED Implementation is going on. New people are contributing to it.

Issues:

API Refactoring

  • Soprasteria is working on the API Refactoring - unify of configuration, similar calls on each API parts.

Varia

  • Andreas Schuler ([email protected]) will be the head of architect of ELGA will join us in future
⚠️ **GitHub.com Fallback** ⚠️