Maintainer Patch Review Checklist - pevik/ltp GitHub Wiki
Patchset should be tested locally and ideally also in maintainer’s fork in GitHub Actions on GitHub.
Note
|
Travis does only build testing, passing the CI means only that the test compiles fine on variety of different distributions and releases. |
The test should be executed at least once locally and should PASS as well.
Commit messages should have
-
Author’s
Signed-off-by
tag -
Committer’s
Reviewed-by
orSigned-off-by
tag -
Check also mailing lists for other reviewers / testers tags, notes and failure reports
-
Fixes: hash
if it fixes particular LTP commit -
Fixes: #N
if it fixes github issue number N, so it’s automatically closed
After patch is accepted or rejected, set correct state and archive in LTP patchwork instance.
Also update LTP WIKI (git URL https://github.com/linux-test-project/ltp.wiki.git)
if touch doc/*.txt
.
New test should
-
Have a record in runtest file
-
Test should work fine with more than one iteration (e.g. run with
-i 100
) -
Have a brief description
-
License: the default license for new tests is GPL v2 or later, use GPL-2.0-or-later; the licence for test (e.g. GPL-2.0) should not change unless test is completely rewritten
-
Old copyrights should be kept unless test is completely rewritten
-
Use new C API
-
Test binaries are added into corresponding '.gitignore' files
-
Check coding style with
make check
(more in C coding style) -
Docparse documentation
-
If a test is a regression test it should include tags (more in Test tags)
-
When rewriting old tests, uClinux support should be removed (project has been discontinued). E.g. remove
#ifdef UCLINUX
, replaceFORK_OR_VFORK()
with simplefork()
orSAFE_FORK()
.
-
Use new shell API
-
Check coding style with
make check
(more in Shell coding style) -
If a test is a regression test it should include related kernel or glibc commits as a comment
For patchset touching library please check also LTP Library API Writing Guidelines.