2020 11 29 Meeting - overlord-supreme/checkers GitHub Wiki

time: 2020-11-29T17:00:00-05  
attending:  
- Peter Mangelsdorf
- Henry Dang

Last Minute Stuff

Two Problems

In General

  • avoid void in the future
  • make everything into a parameter (makes testing much easier)

Board and PlayerManager are Cyclical

  • cannot test these
  • solve: move player into same assembly as board
    • (put player.cs in same folder as board.cs)

Board.cs

  • for unit tests, not possible
  • impossible to test because of UI and logic mixing together
  • mocking out ui is expensive
  • refactoring current code to be ui-free also expensive

Example Untestable Code

  • Board.checkSpace()
    • needs to be broken up further
    • or...
      • make each void method mocked with empty contents
        • show that it calls

Lost Cause?

  • Peter: Should have asked professor about PlayMode testing
  • Peter: Dependency Injection?
  • Henry: Too Late for that
  • Henry: Make Logical Methods public
  • Peter: Show Network/Side Effects

PlayMode Unit Tests?

  • Peter: could do these instead
  • Henry: Prof. will not like these

Are the other teams using Unity?

  • Henry: They might not be doing unit testing either
  • Peter: Could try reaching out/asking them

Review of Syllabus

  • static analysis
    • visual studio has this with its linter
  • id
    • add to start screen

Peter's Anticipated Changes

  • playermanager.raycastMouse()
  • board.checkSpace()
    • make outOfBounds()
    • make calcJump()
  • henry: merge to master, then push to master
  • henry: I will check back at 07:00

Misc