Project Part 3 Feedback - nklose/CMPUT301 GitHub Wiki

Project part 3 feedback

Code base of Prototype -- Good(2)

  • The code looks good.
  • Basic classes have been implemented.
  • You use 'Activities' package to put all the activities classes, which is good. But the name for the package usually starts with lowercase letter. So, name it 'activities' is much better.
  • Similarly, you can create new packages to put the rest of the classes to organize the classes better.

Tangible Demo -- Good(1)

  • The project is demoable.
  • Some rough edges exist but it's ok since the project hasn't been completed yet.

Code doc -- Unsatisfactory(0)

  • Some comment.
  • Before the class signature, you need to put comment to describe the function of the class. Some classes do not have comment.
  • Where is your Javadoc? After inserting the Javadoc to the code, you need to go to 'project'->'generate Javadoc'. The Javadoc will be created under the package 'doc' automatically. Otherwise, there is no Javadoc.

Test Cases -- Unsatisfactory(0)

  • There is no 'src' under the test packages.

OOD -- Excellent(2)

  • The code follows M, V, C pattern.
  • The UML diagram looks good.

Release Planning -- Excellent(1)

  • The planning looks good.

Addressing Feedback -- Excellent(1)

  • The feedback has been addressed.

Summary -- Score(7)

  • Be careful when you prepare the deliverables. Double check if all docs and codes have been uploaded correctly.