Coding Standards - ngageoint/opensphere-desktop GitHub Wiki
The application makes use of a set of formatting standards and naming conventions, as well as various tools to enforce good coding practices (PMD, Checkstyle, FindBugs, etc.). Code formatter templates for Eclipse are provided within the Core application. Import these files directly into Eclipse to make use of the Project Standards. Contributions to the application baseline may be either rejected or re-formatted to match application standards.
Import the editor template:
- Window->Preferences, Java->Editor->Templates
- Click import and select core/eclipse/templates.xml
Import the Java code template:
- Window->Preferences, Java->Code Style->Code Templates
- Click import and select core/eclipse/codetemplates.xml
Import the preferences:
- File->Import, General->Preferences, Next
- Click Browse and select core/eclipse/preferences.epf
Import the code preferences:
- File->Import, General->Preferences, Next
- Click Browse and select core/eclipse/codepreferences.epf
The OpenSphere Desktop code format is provided as a pre-configured template for use with Eclipse. To import the template into Eclipse:
- Window->Preferences, Java->Code Style->Formatter
- Click import and select core/eclipse/formatter.xml
The OpenSphere Style Guide is outlined in detail below. A brief summary is provided here.
- Tab Policy: Spaces only, indent each level by 4 spaces
- Braces: Opening and closing curly braces must always be on a new line at the level of the declaring block. Closing braces must be on their own line (e.g.: the 'else' keyword must not be on the same line as the closing brace from the preceding if block. Array Initializers may be declared on a single line if desired. Lambda bodies must be declared on the next line, and indented one level.
- Whitespace: A single space should follow every comma, closing parenthesis, operator (assignment, addition, subtraction, multiplication, division, lamda arrow, etc.), and after the ellipses in vararg parameters. A single space should precede every operator, opening parenthesis of a control block ('if', 'for', 'while' 'do while', 'synchronized', 'try-with-resources', 'catch', 'assert', 'return', and 'throw'). No whitespace should ever precede a comma, colon, semi-colon, unary operator, postfix operator, or the opening parenthesis of a method declaration. No whitespace should ever follow a unary operator, prefix operator, closing parenthesis of a cast.
- Blank Lines: A single blank line should always follow the following: package declaration, the last import declaration, each import group (as defined by the second-level package name, such as 'java.util'), each declared member field in a class, each closing brace. Multiple blank lines should be collapsed to a single blank line.
- New lines: A new line should be used in the following circumstances: An empty class body (anonymous or declared), an empty method body or other block, after labels, at the end of every file, and after each annotation (class, method, or local variables), before control statements following blocks, such as an 'else' in an 'if' statement, a 'catch' and / or 'finally' in a 'try' statement, a 'while' in a 'do' statement. 'else if' should be on the same line (no newline between 'else' and 'if').
- Line Wrapping: The width of a single line should not exceed 130 characters. Wrapped lines should be indented two spaces.
- Comments: Every member field, class, enum, or other documentable item MUST be documented using JavaDoc style comments, REGARDLESS OF VISIBILITY, including ALL PRIVATE MEMBERS. HTML may be used to provide formatting in JavaDoc comments. Single-line JavaDoc may be collapsed such that the opening mark ('/**'), comment, and closing mark ('*/') are all on the same line. Every parameter must be documented, including type arguments. Every return statement and exception condition must be documented. Overriding / Implemented members should use the '{@inheritDoc}' on the subclass, and provide a '@see' tag to the declared method.
The configuration of the Checkstyle utility is provided in three files, within the root project. These files are used during automated builds to validate the format and structure of the code within the baseline. The files are src/main/resources/checkstyle-config.xml, src/main/resources/checkstyle-suppressions.xml and src/main/resources/checkstyle-todo-config.xml. Developers are encouraged to install the Checkstyle plugin into Eclipse, and import these configuration files into the plugin's configuration for realtime feedback on formatting issues before checkin occurs.
To configure the Eclipse Checkstyle Plugin, open the Eclipse preferences through the Window->Preferences menu, and select "Checkstyle" in the left side of the window. In the configuration screen, Check the following boxes:
- Warn before losing configured file sets
- Include rule names in violation messages
- Include module id (if available) in violation messages
- Limit Checkstyle markers per resource to '100'
- Run Checkstyle in background on full builds.
To add the Checkstyle configuration to the Plugin, click 'New' in the 'Global Check Configurations' section. In the resulting popup, change the 'Type' field to 'Project Relative Configuration', in the 'Name' field, enter 'OpenSphere Checks'. Click 'Browse' and navigate to 'src/main/resources/checkstyle-config.xml', and click 'OK'. Click 'OK' to save the configuration changes.
The configuration of the PMD utility is provided in the root project. Application-specific rules are defined in the core/pmd-config.xml file, which may be used with the Eclipse PMD plugin.
FindBugs is enforced at build time through the continuous build architecture. Conformity may be verfied using the Eclipse FindBugs plugin.
OpenSphere[1] Java Style Guide
This document serves as the complete definition of OpenSphere's coding standards for source code in the Java™ Programming Language. A Java source file is described as being in OpenSphere Style if and only if it adheres to the rules herein.
Like other programming style guides, the issues covered span not only aesthetic issues of formatting, but other types of conventions or coding standards as well. However, this document focuses primarily on the hard-and-fast rules that we follow universally, and avoids giving advice that isn't clearly enforceable (whether by human or tool).
Finally, though the use of the Eclipse IDE is certainly not required, a pre-configured implementation of this guide is provided for use in the Eclipse IDE, and is located at /eclipse/open-sphere-formatter.xml.
In this document, unless otherwise clarified:
- The term class is used inclusively to mean an "ordinary" class, enum class, interface or annotation type (
@interface
). - The term member (of a class) is used inclusively to mean a nested class, field, method, or constructor; that is, all top-level contents of a class except initializers and comments.
- The term comment always refers to implementation comments. We do not use the phrase "documentation comments", instead using the common term "Javadoc."
Other "terminology notes" will appear occasionally throughout the document.
Example code in this document is non-normative. That is, while the examples are in OpenSphere Style, they may not illustrate the only stylish way to represent the code. Optional formatting choices made in examples should not be enforced as rules.
The source file name consists of the case-sensitive name of the top-level class it contains (of which there is exactly one), plus the .java
extension.
Source files are encoded in UTF-8.
Aside from the line terminator sequence, the ASCII horizontal space character (0x20) is the only whitespace character that appears anywhere in a source file. This implies that:
- All other whitespace characters in string and character literals are escaped.
- Tab characters are not used for indentation.
For any character that has a special escape sequence (\b
, \t
, \n
, \f
, \r
, \"
, \'
and \\
), that sequence is used rather than the corresponding octal (e.g. \012
) or Unicode (e.g. \u000a
) escape.
For the remaining non-ASCII characters, either the actual Unicode character (e.g. ∞
) or the equivalent Unicode escape (e.g.
\u221e
) is used. The choice depends only on which makes the code easier to read and understand, although Unicode escapes outside string literals and comments are strongly discouraged.
Tip: In the Unicode escape case, and occasionally even when actual Unicode characters are used, an explanatory comment can be very helpful.
Examples:
Example | Discussion |
---|---|
String unitAbbrev = "μs"; |
Best: perfectly clear even without a comment. |
String unitAbbrev = "\u03bcs"; // "μs" |
Allowed, but there's no reason to do this. |
String unitAbbrev = "\u03bcs"; // Greek letter mu, "s" |
Allowed, but awkward and prone to mistakes. |
String unitAbbrev = "\u03bcs"; |
Poor: the reader has no idea what this is. |
return '\ufeff' + content; // byte order mark |
Good: use escapes for non-printable characters, and comment if necessary. |
Tip: Never make your code less readable simply out of fear that some programs might not handle non-ASCII characters properly. If that should happen, those programs are broken and they must be fixed.
A source file consists of, in order:
- License or copyright information, if present
- Package statement
- Import statements
- Exactly one top-level class
Exactly one blank line separates each section that is present.
If license or copyright information belongs in a file, it belongs here.
The package statement is not line-wrapped. The column limit (Section 4.4, Column limit: 130) does not apply to package statements.
Wildcard imports, static or otherwise, are not used.
Import statements are not line-wrapped. The column limit (Section 4.4, Column limit: 130) does not apply to import statements.
Imports are ordered as follows:
- All static imports in a single block.
- Non-static imports in blocks by top-level domain name. The order of the blocks should be as follows: java, javafx, javax, org, com, then all others.
If there are both static and non-static imports, a single blank line separates the two blocks.
Within each block the imported names appear in ASCII sort order. (Note: this is not the same as the import statements being in ASCII sort order, since '.' sorts before ';'.)
Static import is not used for static nested classes. They are imported with normal imports.
Each top-level class resides in a source file of its own.
The order you choose for the members and initializers of your class can have a great effect on learnability. As a guideline, classes should be ordered as follows: constants, fields, initializers, static factory methods, constructors, followed by all other methods (favoring public methods at the top through private methods at the bottom). However, there's no single correct recipe for how to do it; different classes may order their contents in different ways.
What is important is that each class uses some logical order, which its maintainer could explain if asked. For example, new methods are not just habitually added to the end of the class, as that would yield "chronological by date added" ordering, which is not a logical ordering.
When a class has multiple constructors, or multiple methods with the same name, these appear sequentially, with no other code in between (not even private members).
Terminology Note: block-like construct refers to the body of a class, method or constructor. Note that, by Section 4.8.3.1 on array initializers, any array initializer may optionally be treated as if it were a block-like construct.
Braces are used with if
, else
, for
, do
and while
statements, even when the body is empty or contains only a single statement.
Braces follow the [Allman] (https://en.wikipedia.org/wiki/Indent_style#Allman_style) style for nonempty blocks and block-like constructs:
- Line break before the opening brace.
- Line break after the opening brace.
- Line break before the closing brace.
- Line break after the closing brace.
Examples:
return new MyClass()
{
@Override
public void method()
{
if (condition())
{
try
{
something();
}
catch (ProblemException e)
{
recover();
}
}
else if (otherCondition())
{
somethingElse();
}
else
{
lastThing();
}
}
};
A few exceptions for enum classes are given in Section 4.8.1, Enum classes.
Each time a new block or block-like construct is opened, the indent increases by four spaces. When the block ends, the indent returns to the previous indent level. The indent level applies to both code and comments throughout the block. (See the example in Section 4.1.2, Nonempty blocks: Allman Style.)
Each statement is followed by a line break.
Java code has a column limit of 130 characters. Except as noted below, any line that would exceed this limit must be line-wrapped, as explained in Section 4.5, Line-wrapping. Exceptions:
- Lines where obeying the column limit is not possible (for example, a long URL in Javadoc, or a long JSNI method reference).
- package and import statements (see Sections 3.2 Package statement and 3.3 Import statements).
- Command lines in a comment that may be cut-and-pasted into a shell.
Terminology Note: When code that might otherwise legally occupy a single line is divided into multiple lines, this activity is called line-wrapping.
There is no comprehensive, deterministic formula showing exactly how to line-wrap in every situation. Very often there are several valid ways to line-wrap the same piece of code.
Note: While the typical reason for line-wrapping is to avoid overflowing the column limit, even code that would in fact fit within the column limit may be line-wrapped at the author's discretion.
Tip: Extracting a method or local variable may solve the problem without the need to line-wrap.
The prime directive of line-wrapping is: prefer to break at a higher syntactic level. Also:
- When a line is broken at a non-assignment operator the break comes before the symbol.
- This also applies to the following "operator-like" symbols:
- the dot separator (
.
) - the two colons of a method reference (
::
) - an ampersand in a type bound (
<T extends Foo & Bar>
) - a pipe in a catch block (
catch (FooException | BarException e)
).
- the dot separator (
- This also applies to the following "operator-like" symbols:
- When a line is broken at an assignment operator the break typically comes after the symbol, but either way is acceptable.
- This also applies to the "assignment-operator-like" colon in an enhanced
for
("foreach") statement.
- This also applies to the "assignment-operator-like" colon in an enhanced
- A method or constructor name stays attached to the open parenthesis (
(
) that follows it. - A comma (
,
) stays attached to the token that precedes it.
Note: The primary goal for line wrapping is to have clear code, not necessarily code that fits in the smallest number of lines.
When line-wrapping, each line after the first (each continuation line) is indented at least +4 from the original line.
When there are multiple continuation lines, indentation may be varied beyond +4 as desired. In general, two continuation lines use the same indentation level if and only if they begin with syntactically parallel elements.
Section 4.6.3 on Horizontal alignment addresses the discouraged practice of using a variable number of spaces to align certain tokens with previous lines.
A single blank line appears:
- Between consecutive members or initializers of a class: fields, constructors, methods, nested classes, static initializers, and instance initializers.
- Between statements, as needed to organize the code into logical subsections.
- As required by other sections of this document (such as Section 3, Source file structure, and Section 3.3, Import statements).
Multiple consecutive blank lines are not permitted.
Beyond where required by the language or other style rules, and apart from literals, comments and Javadoc, a single ASCII space also appears in the following places only.
- Separating any reserved word, such as if, for or catch, from an open parenthesis (
(
) that follows it on that line - Before any open curly brace (
{
), with two exceptions:-
@SomeAnnotation({ a, b })
(no space is used) -
String[][] x = {{"foo"}};
(no space is required between{{
, by item 6 below)
-
- On both sides of any binary or ternary operator. This also applies to the following "operator-like" symbols:
- the ampersand in a conjunctive type bound:
<T extends Foo & Bar>
- the pipe for a catch block that handles multiple exceptions:
catch (FooException | BarException e)
- the colon (
:
) in an enhancedfor
("foreach") statement - the arrow in a lambda expression: (String str) -> str.length() but not
- the two colons (
::
) of a method reference, which is written likeObject::toString
- the dot separator (
.
), which is written likeobject.toString()
- the ampersand in a conjunctive type bound:
- After
,:;
unless at the end of a line - Between the type and variable of a declaration:
List<String> list
- Just inside both braces of an array initializer
new int[] { 5, 6 }
is valid
This rule is never interpreted as requiring or forbidding additional space at the start of a line; it addresses only interior space. Space at the end of a line should be removed.
Terminology Note: Horizontal alignment is the practice of adding a variable number of additional spaces in your code with the goal of making certain tokens appear directly below certain other tokens on previous lines.
This practice is not permitted by OpenSphere Style.
Here is an example of alignment:
private int x; // this is aligned
private Color color;
Tip: Alignment can aid readability, but it creates problems for future maintenance. Consider a future change that needs to touch just one line. This change may leave the formerly-pleasing formatting mangled, and that is allowed. More often it prompts the coder (perhaps you) to adjust whitespace on nearby lines as well, possibly triggering a cascading series of reformattings. That one-line change now has a "blast radius." This can at worst result in pointless busywork, but at best it still corrupts version history information, slows down reviewers and exacerbates merge conflicts.
Optional grouping parentheses are omitted only when author and reviewer agree that there is no reasonable chance the code will be misinterpreted without them, nor would they have made the code easier to read. It is not reasonable to assume that every reader has the entire Java operator precedence table memorized.
Here is an example of enum formatting:
private enum Answer
{
/** Yes. */
YES
{
@Override
public String toString()
{
return "yes";
}
},
/** No. */
NO,
/** Maybe. */
MAYBE;
}
Since enum classes are classes, all other rules for formatting classes apply.
Every variable declaration (field or local) declares only one variable: declarations such as int a, b;
are not used.
Local variables are not habitually declared at the start of their containing block or block-like construct. Instead, local variables are declared close to the point they are first used (within reason), to minimize their scope. Local variable declarations typically have initializers, or are initialized immediately after declaration.
Any array initializer is formatted as follows:
new int[] { 0, 1, 2, 3 }
The square brackets form a part of the type, not the variable: String[] args
, not String args[]
.
Terminology Note: Inside the braces of a switch block are one or more statement groups. Each statement group consists of one or more switch labels (either case FOO
: or default:
), followed by one or more statements.
As with any other block, the contents of a switch block are indented +4.
After a switch label, there is a line break, and the indentation level is increased +4, exactly as if a block were being opened. The following switch label returns to the previous indentation level, as if a block had been closed.
Within a switch block, each statement group either terminates abruptly (with a break
, continue
, return
or thrown exception), or is marked with a comment to indicate that execution will or might continue into the next statement group. Any comment that communicates the idea of fall-through is sufficient (typically // fall through
). This special comment is not required in the last statement group of the switch block. Example:
switch (input)
{
case 1:
case 2:
prepareOneOrTwo();
// fall through
case 3:
handleOneTwoOrThree();
break;
default:
handleLargeNumber(input);
}
Notice that no comment is needed after case 1:
, only at the end of the statement group.
Each switch statement includes a default
statement group, even if it contains no code.
Annotations applying to a class, method or constructor appear immediately after the documentation block, and each annotation is listed on a line of its own (that is, one annotation per line). These line breaks do not constitute line-wrapping (Section 4.5, Line-wrapping), so the indentation level is not increased. Example:
@Override
@Nullable
public String getNameIfPresent()
{
...
}
This section addresses implementation comments. Javadoc is addressed separately in Section 7, Javadoc.
Any line break may be preceded by arbitrary whitespace followed by an implementation comment. Such a comment renders the line non-blank.
Block comments are indented at the same level as the surrounding code. They may be in /* ... */
style or // ...
style. For multi-line /* ... */
comments, subsequent lines must start with *
aligned with the *
on the previous line.
/*
* This is // And so /* Or you can
* okay. // is this. * even do this. */
*/
Comments are not enclosed in boxes drawn with asterisks or other characters.
Tip: When writing multi-line comments, use the
/* ... */
style if you want automatic code formatters to re-wrap the lines when necessary (paragraph-style). Most formatters don't re-wrap lines in// ...
style comment blocks.
Trailing comments are never permitted.
Class and member modifiers, when present, appear in the order recommended by the Java Language Specification:
public protected private abstract default static final transient volatile synchronized native strictfp
long
-valued integer literals use an uppercase L
suffix, never lowercase (to avoid confusion with the digit 1
). For example, 3000000000L
rather than 3000000000l
.
Identifiers use only ASCII letters and digits, and, in a small number of cases noted below, underscores. Thus each valid identifier name is matched by the regular expression \w+
.
In OpenSphere Style, special prefixes may be used, but are discoraged. If used, only the following prefixes are permitted:
Prefix | Permitted location |
---|---|
my |
private non-static Member Variables |
our |
class-level static non-final fields |
s |
class-level static non-final fields |
p |
method parameters |
Package names are all lowercase, with consecutive words simply concatenated together (no underscores). For example, com.example.deepspace
, not com.example.deepSpace
or com.example.deep_space
.
Class names are written in [UpperCamelCase] (https://google.github.io/styleguide/javaguide.html#s5.3-camel-case).
Class names are typically nouns or noun phrases. For example, Character
or ImmutableList
. Interface names may also be nouns or noun phrases (for example, List
), but may sometimes be adjectives or adjective phrases instead (for example, Readable
).
There are no specific rules or even well-established conventions for naming annotation types.
Test classes are named starting with the name of the class they are testing, and ending with Test
. For example, HashTest
or HashIntegrationTest
.
Method names are written in [lowerCamelCase] (https://google.github.io/styleguide/javaguide.html#s5.3-camel-case).
Method names are typically verbs or verb phrases. For example, sendMessage
or stop
.
Underscores may appear in JUnit
test method names to separate logical components of the name. One typical pattern is test<MethodUnderTest>_<state>
, for example testPop_emptyStack
. There is no One Correct Way to name test methods.
Constant names use CONSTANT_CASE
: all uppercase letters, with words separated by underscores. But what is a constant, exactly?
Constants are static final fields whose contents are deeply immutable and whose methods have no detectable side effects. This includes primitives, Strings, immutable types, and immutable collections of immutable types. If any of the instance's observable state can change, it is not a constant. Merely intending to never mutate the object is not enough. Examples:
// Constants
static final int NUMBER = 5;
static final ImmutableList<String> NAMES = ImmutableList.of("Ed", "Ann");
static final ImmutableMap<String, Integer> AGES = ImmutableMap.of("Ed", 35, "Ann", 32);
static final Joiner COMMA_JOINER = Joiner.on(','); // because Joiner is immutable
static final SomeMutableType[] EMPTY_ARRAY = {};
enum SomeEnum { ENUM_CONSTANT }
// Not constants
static String nonFinal = "non-final";
final String nonStatic = "non-static";
static final Set<String> mutableCollection = new HashSet<String>();
static final ImmutableSet<SomeMutableType> mutableElements = ImmutableSet.of(mutable);
static final ImmutableMap<String, SomeMutableType> mutableValues =
ImmutableMap.of("Ed", mutableInstance, "Ann", mutableInstance2);
static final Logger logger = Logger.getLogger(MyClass.getName());
static final String[] nonEmptyArray = {"these", "can", "change"};
These names are typically nouns or noun phrases.
Non-constant field names (static or otherwise) are written in [lowerCamelCase] (https://google.github.io/styleguide/javaguide.html#s5.3-camel-case).
These names are typically nouns or noun phrases. For example, computedValues
or index
.
Parameter names are written in [lowerCamelCase] (https://google.github.io/styleguide/javaguide.html#s5.3-camel-case).
One-character parameter names in public methods are not permitted, and must be avoided.
Local variable names are written in [lowerCamelCase] (https://google.github.io/styleguide/javaguide.html#s5.3-camel-case).
Even when final and immutable, local variables are not considered to be constants, and should not be styled as constants.
One-character local variable names are not permitted must be avoided.
Each type variable is named in one of two styles:
- A single capital letter, optionally followed by a single numeral (such as
E
,T
,X
,T2
) - A name in the form used for classes (see Section 5.2.2, Class names), followed by the capital letter
T
(examples:RequestT
,FooBarT
).
Sometimes there is more than one reasonable way to convert an English phrase into camel case, such as when acronyms or unusual constructs like "IPv6" or "iOS" are present. To improve predictability, OpenSphere Style specifies the following (nearly) deterministic scheme.
Beginning with the prose form of the name:
- Convert the phrase to plain ASCII and remove any apostrophes. For example, "Müller's algorithm" might become "Muellers algorithm".
- Divide this result into words, splitting on spaces and any remaining punctuation (typically hyphens).
- Recommended: if any word already has a conventional camel-case appearance in common usage, split this into its constituent parts (e.g., "AdWords" becomes "ad words"). Note that a word such as "iOS" is not really in camel case per se; it defies any convention, so this recommendation does not apply.
- Now lowercase everything (including acronyms), then uppercase only the first character of:
- ... each word, to yield upper camel case, or
- ... each word except the first, to yield lower camel case
- Finally, join all the words into a single identifier.
Note that the casing of the original words is almost entirely disregarded. Examples:
Prose form | Correct | Incorrect |
---|---|---|
"XML HTTP request" | XmlHttpRequest | XMLHTTPRequest |
"new customer ID" | newCustomerId | newCustomerID |
"inner stopwatch" | innerStopwatch | innerStopWatch |
"supports IPv6 on iOS?" | supportsIpv6OnIos | supportsIPv6OnIOS |
"YouTube importer" | YouTubeImporter, YoutubeImporter* |
*Acceptable, but not recommended.
Note: Some words are ambiguously hyphenated in the English language: for example "nonempty" and "non-empty" are both correct, so the method names checkNonempty and checkNonEmpty are likewise both correct.
A method is marked with the @Override
annotation whenever it is legal. This includes a class method overriding a superclass method, a class method implementing an interface method, and an interface method respecifying a superinterface method.
Exception: @Override
may be omitted when the parent method is @Deprecated
.
Except as noted below, it is very rarely correct to do nothing in response to a caught exception. (Typical responses are to log it, or if it is considered "impossible", rethrow it as an AssertionError
.)
When it truly is appropriate to take no action whatsoever in a catch block, the reason this is justified is explained in a comment.
try
{
int i = Integer.parseInt(response);
return handleNumericResponse(i);
}
catch (NumberFormatException ok)
{
// it's not numeric; that's fine, just continue
}
return handleTextResponse(response);
Exception: In tests, a caught exception may be ignored without comment if its name is or begins with expected
. The following is a very common idiom for ensuring that the code under test does throw an exception of the expected type, so a comment is unnecessary here.
try
{
emptyStack.pop();
fail();
}
catch (NoSuchElementException expected)
{
}
When a reference to a static class member must be qualified, it is qualified with that class's name, not with a reference or expression of that class's type.
Foo aFoo = ...;
Foo.aStaticMethod(); // good
aFoo.aStaticMethod(); // bad
somethingThatYieldsAFoo().aStaticMethod(); // very bad
It is extremely rare to override Object.finalize
.
Tip: Don't do it. If you absolutely must, first read and understand Effective Java Item 7, "Avoid Finalizers," very carefully, and then don't do it.
The basic formatting of Javadoc blocks is as seen in this example:
/**
* Multiple lines of Javadoc text are written here,
* wrapped normally...
*/
public int method(String p1)
{
...
}
... or in this single-line example:
/** An especially short bit of Javadoc. */
The basic form is always acceptable. The single-line form may be substituted when there are no at-clauses present, and the entirety of the Javadoc block (including comment markers) can fit on a single line.
One blank line—that is, a line containing only the aligned leading asterisk (*
)—appears between paragraphs, and before the group of "at-clauses" if present. Each paragraph but the first has <p> immediately before the first word, with no space after.
Any of the standard "at-clauses" that are used appear in the order @param
, @return
, @throws
, @deprecated
, and these four types never appear with an empty description. When an at-clause doesn't fit on a single line, continuation lines are indented four (or more) spaces from the position of the @
.
Every parameter in a method signature must have an associated @param
tag.
If a method has a return type other than void
, the @return
tag must be present.
Every declared thrown exception must have an associated @throws
tag (even if the declared exception extends RuntimeException
.
Each Javadoc block begins with a brief summary fragment. This fragment is very important: it is the only part of the text that appears in certain contexts such as class and method indexes.
This is a fragment—a noun phrase or verb phrase, not a complete sentence. It does not begin with A {@code Foo} is a..
., or This method returns...
, nor does it form a complete imperative sentence like Save the record.
. However, the fragment is capitalized and punctuated as if it were a complete sentence.
Tip: A common mistake is to write simple Javadoc in the form
/** @return the customer ID */
. This is incorrect, and should be changed to/** Returns the customer ID. */
.
Javadoc is present for every class (public
, private
, or otherwise
), and every member of such a class (private
, protected
, package and public
), with a few exceptions /notes below.
Additional Javadoc content may also be present, as explained in Section 7.3.4, Non-required Javadoc.
Javadoc is always present on a method that overrides a supertype method, but the content must use the {@inheritDoc}
before optionally declaring behavior that differs from the parent declaration. For Example:
/**
* {@inheritDoc}
* <p>Does some other stuff.</p>
*/
public void foo()
{
}
Other classes and members have Javadoc as needed or desired.
Whenever an implementation comment would be used to define the overall purpose or behavior of a class or member, that comment is written as Javadoc instead (using /**
).
Non-required Javadoc is not strictly required to follow the formatting rules of Sections 7.1.2, 7.1.3, and 7.2, though it is of course recommended.
[1]: Thanks to https://google.github.io/styleguide/javaguide.html for providing a base for this document.