Definition of Done - mhmunem/Grocery-Comparison-App GitHub Wiki
- Unit and/or acceptance tests are added with the code.
- Code follows coding standard.
- Code has no smells.
- Docstrings added to all functions.
- Once feature branch is merged to dev branch than the feature branch should be deleted.
- A sufficient amount of testing needs to be completed (unit, acceptance, manual, integration,...)
- Before a story is marked 'Done' on your project management tool it must have been pushed to your dev branch.
- Dev branch must always be green (i.e. all tests pass, and the project can be built and run from dev at any time).
- UI aspects should adhere to the UI guidelines.
- Data migration has been carried (if needed).
- README and documentation are up to date.
- Work has been reviewed for code quality and design successfully.
- Work has been successfully merged to dev branch.
- Testing by the team has been completed successfully. (e.g. Unit testing, Acceptance testing)
- The Quality Control tests are passed. (e.g. Integration testing, End to end testing)
- Work is tested on all release platforms. (e.g. works on mobile, tablet and desktop)
- Work is checked against the NZ Privacy standards, each criteria is met or discussed as acceptable not to meet.
- Work is checked against the acceptance criteria, each criteria is met or discussed as acceptable not to meet.