Project Management - lyulyul/shine-cluster GitHub Wiki

Code Review

Copy the following template to the PR you've reviewed. When the PR passes a criterion, you mark the criterion with a check and add your analysis. If you didn't check a criterion, do not add a check.

## Code Review Checklist

- [ ] **Code style**: does the code conform the company code style? 
  - Your analysis
- [ ] **Bugs**: does the code have bugs, fail in corner cases? Did you personally run the code?
  - Your analysis
- [ ] **CI step/test**: does existing CI step or test cover the piece of code changed in this PR? Should a new CI step or test be added?
  - Your analysis
- [ ] **Support requests**: does this change incur new support request? does this change follow good patterns in human-computer interface?
  - Your analysis
- [ ] **Installation**: how to install this feature? Does this feature alter existing installation step/script?
  - Your analysis
- [ ] **Documentations**: Is the change reflected on the wiki or on the repo? Does this program support `--help` option?
  - Your analysis