00573: potential memory issues in dcomm library

« 00572 | Issues | 00574 »

Summary: potential memory issues in dcomm library

Created: 2016–06–16 12:58

Status: Released

Category: Bug

From: frankie

Version: 2.3

Released_In: 2.4

Description:

Some users using dcomm in a light client saw warnings in valgrind such as:

==53405== Use of uninitialised value of size 8
==53405==    at 0x398B243A9B: _itoa_word (in /lib64/libc-2.12.so)
==53405==    by 0x398B246652: vfprintf (in /lib64/libc-2.12.so)
==53405==    by 0x398B269608: vsprintf (in /lib64/libc-2.12.so)
==53405==    by 0x398B24F2B7: sprintf (in /lib64/libc-2.12.so)
==53405==    by 0x1DC6DC41: DCF_ReadConfig (dcomm_utils.c:1138)
==53405==    by 0x1DC5D635: DCF_StartClient (dcomm_client.c:2035)

==53405==  Uninitialised value was created by a heap allocation
==53405==    at 0x34A1FA2E: malloc (vg_replace_malloc.c:270)
==53405==    by 0x1DC5C646: DCF_InitClient (dcomm_client.c:450)
==53405==    by 0x1DC5D60D: DCF_StartClient (dcomm_client.c:2034)

---

Comments

---

« 00572 | Issues | 00574 »

Associated Commits

| commit | 27a5b1db8b45bbb8e62c1718d10475cda142bd93 link5 | || | Author: | Frank Graffagnino | | Date: | Thu Jun 16 13:04:21 2016 -0500 | | Message: | [@Issue 00573: Fixing potential memory issues in dcomm library This should fix the valgrind warnings reported in the issue. Also, it looks like there may have been some dangerous behavior for light clients that weren't using a config file (rather using environment variables) because it looks like fixed_frame was never initialized. This should fix that. @] |

Affected Files:

lib_Darwin/libd_comm_tc.a              | Bin 1023576 -> 1019928 bytes
 lib_Linux_FC3/libd_comm_tc.a           | Bin 480162 -> 480230 bytes
 lib_Linux_FC3/libd_comm_tc_s.so        | Bin 329914 -> 330009 bytes
 lib_Linux_FC3_x86_64/libd_comm_tc.a    | Bin 835230 -> 900806 bytes
 lib_Linux_FC3_x86_64/libd_comm_tc_s.so | Bin 425210 -> 466114 bytes
 lib_Win32/libd_comm_tc.dll             | Bin 593465 -> 593465 bytes
 lib_Win64/libd_comm_tc.def             | 299 ++++++++++++++++±---------------
 lib_Win64/libd_comm_tc.dll             | Bin 344619 -> 344619 bytes
 8 files changed, 150 insertions(+), 149 deletions(-)

| commit | b1d467e1dbf8bb517ceca42a6225532805784315 link6 | || | Author: | Frank Graffagnino | | Date: | Thu Jun 16 18:01:12 2016 -0500 | | Message: | [@EDGE issue 00573: fixing potential memory issues in DCOMM Some users using dcomm in light clients saw warnings in valgrind such as: ==53405== Use of uninitialised value of size 8 ==53405== at 0×398B243A9B: _itoa_word (in /lib64/libc-2.12.so) ==53405== by 0×398B246652: vfprintf (in /lib64/libc-2.12.so) ==53405== by 0×398B269608: vsprintf (in /lib64/libc-2.12.so) ==53405== by 0×398B24F2B7: sprintf (in /lib64/libc-2.12.so) ==53405== by 0×1DC6DC41: DCF_ReadConfig (dcomm_utils.c:1138) ==53405== by 0×1DC5D635: DCF_StartClient (dcomm_client.c:2035) ==53405== Uninitialised value was created by a heap allocation ==53405== at 0×34A1FA2E: malloc (vg_replace_malloc.c:270) ==53405== by 0×1DC5C646: DCF_InitClient (dcomm_client.c:450) ==53405== by 0×1DC5D60D: DCF_StartClient (dcomm_client.c:2034) These changes should fix those issues. @] |

Affected Files:

src/dcomm/src/dcomm_client.c | 1 +
 src/dcomm/src/dcomm_utils.c  | 9 +++++++±
 2 files changed, 9 insertions(+), 1 deletion(-)