00488: dsp_jpeggrab can segfault if large images are requested after a small one

« 00487 | Issues | 00489 »

Summary: dsp_jpeggrab can segfault if large images are requested after a small one

Created: 2013–03–13 15:14

Status: Released

Category: Bug

From: frankie

Version: 2.2

Released_In: 2.4

Description:

The dsp_jpeggrab plugin, which is used to send images and MJPEG video to the web browser using the WCS, can seg fault if a width and height is requested that is large after the initial calls request a smaller image.

This is due to an internal buffer not resizing appropriately.

---

Comments

---

« 00487 | Issues | 00489 »

Associated Commits

| commit | 6ab6f91072a17c3fa2e3356d0ce598987c2dd7ee link5 | || | Author: | Frank Graffagnino | | Date: | Tue Mar 19 15:10:16 2013 -0500 | | Message: | [@Issue 00488: Fixed potential seg fault in dsp_jpeggrab The sizing of the output image buffer was not being done correctly. This update fixes that. It also adds in a check to limit the requested image size to the max viewport size of the current platform. @] |

Affected Files:

plugin_Darwin/dsp_jpeggrab.so    | Bin 35308 -> 35488 bytes
 plugin_Linux_FC3/dsp_jpeggrab.so | Bin 45435 -> 45756 bytes
 plugin_Win32/dsp_jpeggrab.dll    | Bin 453197 -> 453413 bytes
 3 files changed, 0 insertions(+), 0 deletions(-)

| commit | d2d97283e0c4eea978138ca5feb03200f001c613 link6 | || | Author: | Frank Graffagnino | | Date: | Tue Mar 19 14:11:48 2013 -0600 | | Message: | [@Issue 00488: Added a check in dsp_jpeggrab to limit output size to max viewport size @] |

Affected Files:

src/plugins/dsp_jpeggrab.c | 9 +++++++++
 1 file changed, 9 insertions(+)

| commit | 5cb860864d224e373ed7dafb1c213e918d417fdf link7 | || | Author: | Frank Graffagnino | | Date: | Wed Mar 13 14:18:46 2013 -0600 | | Message: | [@Issue 00488: Fixing seg fault in dsp_jpeggrab Looks like, for some odd reason, I was using the size of the viewport to size the output buffer that I was calling glReadPixels to fill. Fixed this so that the size of the output is related to the destination buffer. @] |

Affected Files:

src/plugins/dsp_jpeggrab.c | 29 +++++++++++++++±------------
 1 file changed, 16 insertions(+), 13 deletions(-)

| commit | 90e0e1cb56ff1ad15fb564caca6d3d384d0a30a0 link8 | || | Author: | Frank Graffagnino | | Date: | Wed Mar 13 14:18:46 2013 -0600 | | Message: | [@Issue 00488: Fixing seg fault in dsp_jpeggrab Looks like, for some odd reason, I was using the size of the viewport to size the output buffer that I was calling glReadPixels to fill. Fixed this so that the size of the output is related to the destination buffer. @] |

Affected Files:

src/plugins/dsp_jpeggrab.c | 29 +++++++++++++++±------------
 1 file changed, 16 insertions(+), 13 deletions(-)