00398: add "read only" mode for DCOMM

« 00397 | Issues | 00399 »

Summary: add "read only" mode for DCOMM

Created: 2011–10–05 11:44

Status: Released

Category: Request

From: frankie

Version: 2.2

Released_In: 2.3

Description:

It would nice if there was a DCOMM tcl command for a client which could toggle it in and out of a read-only mode. There are many dcomm clients which should not have information sent back to the manager and should be read-only. Scripts and plugins which adjust items in the scene can sometimes cause unnecessary traffic.

Also, calling the tcl command without an argument to change it should report the current read-only state of the plugin.

---

Comments

frankie November 14, 2012, at 03:02 PM: This has been added in. There is now a new command line option to the dcomm plugin of "-read_only" which will place the plugin into a read-only mode. Similarly, there is a "-noread_only" to overwrite it back into read-write mode. For example, the following can go into a command line block or on the actual command line:

-plugin comm '-read_only'

or

-plugin comm '-noread_only'

There is also a new tcl command to query the value at run-time:

doug.plugin dcomm is_read_only    # returns 1 if dcomm is running read-only, 0 otherwise

---

« 00397 | Issues | 00399 »

Associated Commits

| commit | a0889c5a988f9d94384da920d9458a1ac22ef010 link5 | || | Author: | Frank Graffagnino | | Date: | Wed Nov 14 19:10:29 2012 -0600 | | Message: | [@Issue 00398, 00448, 00455: Added in dcomm read-only mode, fixes for dcomm hanging on tcl command, and updated mobile WCS template These issues were loosely interrelated, so they got committed together. For 00398, the read-only mode was added in via the updated plugins. Now, on the command line to the dcomm plugin you can pass in "-read_only" or "-noread_only" to enable and disable read-only mode. There is a new tcl command to query the state, which is why the WCS xml template and mobile pages were updated to reflect this new telemetry. This lead to issue 00448, since when I added in the connected field to the xml, i forgot to update the mobile pages also to include it. So while I added in the read-only mode to both, I also fixed the mobile pages to have the connected field in the general and dcomm status pages. Issue 00455 got committed at the same time because it is also in the dcomm plugins where I applied the fix. Rather than trying to fix the source of the hang, I changed it to where clients always return −1, as it is easier to query this information from the manager directly. Also, it is probably more effecient since it doesn't have to tunnel the information through a tunnel blocking all communication until an answer returns. @] |

Affected Files:

gui/html/lte_edge_root.xsl        |   3 +++
 gui/html/templates/mobile.tmpl    |   6 ++++++
 gui/html/templates/xml_dcomm.tmpl |   1 +
 plugin_Darwin/dsp_dcomm_tc.so     | Bin 229280 -> 229340 bytes
 plugin_Linux_FC3/dsp_dcomm_tc.so  | Bin 68950 -> 69135 bytes
 plugin_Win32/dsp_dcomm_tc.dll     | Bin 1009518 -> 1009554 bytes
 6 files changed, 10 insertions(+)

| commit | 5888af43a9dd0807cd03a042f839e954558b13a3 link6 | || | Author: | Frank Graffagnino | | Date: | Wed Nov 14 15:03:40 2012 -0600 | | Message: | [@Issue 00398: Added in read-only mode for DCOMM plugin This adds in two command line options to turn on and disable read-only mode in the dcomm plugin. Also, a new tcl command was added to query the mode at runtime from tcl. @] |

Affected Files:

src/plugins/dsp_dcomm_tc.c | 31 +++++++++++++++++++++++++++++±
 1 file changed, 30 insertions(+), 1 deletion(-)