00159: dsp_fltloader.c doesn't handle "." (dots) in pathname or show warnings

« 00158 | Issues | 00160 »

Summary: dsp_fltloader.c doesn't handle "." (dots) in pathname or show warnings

Created: 2009–06–10 16:14

Status: Released

Category: Bug

From: frankie

Version: 2.0

Released_In: 2.1

Description:

The openflight loader (dsp_fltloader.c) has a bug where a dot in the filename will cause the plugin to exit.

Also, when the plugin does fail to load a model, it doesn't give good warning messages about why it did fail.

---

Comments

frankie June 10, 2009, at 04:21 PM: Got this one fixed. Added the warnings and also fixed the "." issue. The following patch file can be used to patch the source code in src.dist/plugins if you want to compile in the fix without waiting for the next release.

Attach:0001-Issue-00159-Fixed-.-bug-and-added-warnings.patch

The patch can be applied with the command:

patch -p1 < 0001-Issue-00159-Fixed-.-bug-and-added-warnings.patch

---

« 00158 | Issues | 00160 »

Associated Commits

| commit | 53fb03db9c4a9c97d4f8e175913f382e367a2e5f link6 | || | Author: | Frankie Graffagnino | | Date: | Wed Jun 10 16:33:39 2009 -0500 | | Message: | [@Issue 00159: Recompiled fltloader on FC3 machine @] |

Affected Files:

plugin_Linux_FC3/dsp_fltloader.so | Bin 47507 -> 51253 bytes
 1 file changed, 0 insertions(+), 0 deletions(-)

| commit | 75af16db0b39bba50ca79500fb52cf0ddd6c8b06 link7 | || | Author: | Frank Graffagnino | | Date: | Wed Jun 10 16:18:58 2009 -0500 | | Message: | [@Issue 00159: Fixed "." bug and added warnings The strchr function was converted to a strrchr to fix the issue with .'s in the pathname. Also, when the plugin exits due to not being able to open the file, or incorrect version, etc., it now calls LogWarning to report it to the user. @] |

Affected Files:

src.dist/plugins/dsp_fltloader.c | 26 ++++++++++++++++++++±----
 1 file changed, 21 insertions(+), 5 deletions(-)