Code Review - iToto/developmentCycle GitHub Wiki
Our current development practice does not involve any sort of code review. This is something we need to change. It has occurred that some code was pushed that wasn’t up to scruff and has caused issues both with our build system and for the end users.
A pretty good intro to code reviews can be found here. The really pertinent points are as follows:
- This isn’t a design review
- Don’t take critiques personally
- Don’t review something you know nothing about
- Before reviewing, learn what the code is supposed to do/fix
- Do a quick static analysis of changes first
- Test the code