user { "tim":
  ensure => present,
  gid => "fearme",
  groups => ["adm", "staff", "root", "fearmenot"],
  membership => minimum,
  shell => "/bin/bash",
  require => [ Group["fearme"],
               Group["fearmenot"]
             ]
}

It looks like you are using a defined type called apt::ppa, so you would need to capitalize all the words of the type:

require => Apt::Ppa['ppa:git-core/ppa'],

If you were declaring a class called apt::ppa, you would want to require the class:

require => Class['apt::ppa'], 

lvm::volume { 'kickstart':
  ensure => present,
  vg => 'vg_images',
  pv => '/dev/sda5',
  fstype => 'ext4',
  size => '10G',
}

file { '/var/ks':
  ensure => directory,
}
/dev/vg_images/kickstart

file_line { 'kickstart_dir':
  path => '/etc/fstab',
  line => '/dev/vg_images/kickstart /var/ks ext4 defaults 1 2',
  require => [ 
        File['/var/ks' ],
        Lvm::Volume[ 'kickstart' ],
             ],
} 

file { '/etc/motd':
  ensure  => file,
  backup  => false,
  content => template('motd/motd.erb'),
}

$arRepoAdmPublicKeys = hiera('repoadmpubkeys')

file { '/home/repoadm/.ssh/authorized_keys':
  ensure  => file,
  owner   => 'repoadm',
  mode    => '700',
  content => inline_template("<% @arRepoAdmPublicKeys.each do |szKey| -%>
<%= szKey %>
<% end %>"),
  require => File['/home/repoadm/.ssh'],
}

sonar.jdbc.username=sonar

file_line { 'sonar_username':
  path => '/opt/sonar/conf/sonar.properties',
  line => 'sonar.jdbc.username=sonar',
  match => '^.sonar.jdbc.username=',
}
sonar.jdbc.password=sonar

file_line { 'sonar_password':
  path => '/opt/sonar/conf/sonar.properties',
  line => 'sonar.jdbc.password=sonarpasswd',
  match => '^.sonar.jdbc.password=',
}

sonar.jdbc.url=jdbc:postgresql:

file_line { 'sonar_postgresql':
  path => '/opt/sonar/conf/sonar.properties',
  line => 'sonar.jdbc.url=jdbc:postgresql://localhost/sonar',
  match => '^.sonar.jdbc.url=jdbc:postgresql:',
} 

augeas { 'hyperthread_enable':
 context => '/files/etc/default/grub',
 changes => [ 'set GRUB_CMDLINE_LINUX \'"\"noapic vconsole.font=latarcyrheb-sun16 selinux=0 $([ -x /usr/sbin/rhcrashkernel-param ] && /usr/sbin/rhcrashkernel-param || :) acpi=ht rhgb quiet\""\'', ], notify => Exec['grub-update'], }'set GRUB_CMDLINE_LINUX "\"noapic vconsole.font=latarcyrheb-sun16 selinux=0 \$([ -x /usr/sbin/rhcrashkernel-param ] && /usr/sbin/rhcrashkernel-param || :) acpi=ht rhgb quiet\""',
  exec { 'grub-update': refreshonly => true, command => '/sbin/grub2-mkconfig -o /boot/grub2/grub.cfg', 
}

netconfig:
 vnic02:
  nic_name: eth2
  ip_addr: 10.1.2.3
  netmask: 255.255.255.0
 vnic03:
  nic_name: eth3
  ip_addr: 10.1.3.3
  netmask: 255.255.255.0
 vnic04:
  nic_name: eth4
  ip_addr: 10.1.4.3
  netmask: 255.255.255.0 

$netconfigs = { 
  vnic02 => { nic_name => 'eth2', ip_addr => '10.1.2.3', netmask => '255.255.255.0', },
  vnic03 => { nic_name => 'eth3', ip_addr => '10.1.3.3', netmask => '255.255.255.0', },
  vnic04 => { nic_name => 'eth4', ip_addr => '10.1.4.3', netmask => '255.255.255.0', }, 
}

define notify_netconfigs($nic_name, $ip_addr, $netmask) { notify { "currently looping NIC: $nic_name, $ip_addr, $netmask": } }
$netconfigs = hiera("netconfig") create_resources( notify_netconfigs, $netconfigs ) 

class server-of-diskless-boot { 
  $szNetworkInterfaceName = hiera( 'NetworkInterfaceName', '' ), 
  $szServiceIpAddress = hiera( 'ServiceIpAddress', '172.16.1.3' ), ) {
  #if $szNetworkInterfaceName not set then set it 
  if ( $szNetworkInterfaceName == '' ) { 
    # # Facter: interfaces (Array of interfaces), grab the second entry.
    notify{ "Network interface name not set.": } 
    $arInterfaceList = split($interfaces, ',')
    $szNicName = $arInterfaceList[1] 
  } else { 
    $szNicName = $szNetworkInterfaceName 
  }
  notify{ "NIC: $szNicName ( $szServiceIpAddress )": }
} # end class.

network::if::static { "$szNicName": ensure => 'up', ipaddress => "$szServiceIpAddress", netmask => '255.255.255.0', }

 package { 'rsh-server': ensure => present, }

augeas { 'rsh_enable': context => '/files/etc/xinetd.d/rsh', changes => [ 'set service/disable "no"', ], require => Package [ 'rsh-server' ], notify => Service['xinetd'], }

service { 'xinetd': ensure => running, enabled => true, }

exec { 'get_VBoxLinuxAdditions_run': 
  creates => '/var/puppetextras/VBoxLinuxAdditions.run', 
  command => '/usr/bin/wget --directory-prefix=/var/puppetextras http://10.1.233.3:/storage/puppet/VBoxLinuxAdditions.run', 
  require => File [ '/var/puppetextras' ], 
}

exec { 'install_VirtualBoxAdditions': 
  creates => '/opt/VBoxGuestAdditions-4.3.18', 
  command => '/var/puppetextras/VBoxLinuxAdditions.run', 
  require => File [ '/var/puppetextras/VBoxLinuxAdditions.run' ], 
}

user
generate a password thingy
host ops
Change the host name and domain

See: http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/set-hostname.html

sonar.jdbc.url=jdbc:postgresql:

file_line { 'set_sonar_db_postgresql': 
  path => "$SONARRUNNER_CONF", line => 'sonar.jdbc.url=jdbc:postgresql://localhost/sonar',
  match => '^.sonar.jdbc.url=jdbc:postgresql:', 
  require => Exec [ 'install_sonar' ], 
} 

# ---------------------------------------------------------------------
# ------------------------
sub GetFile { 
  my $szHttpBaseSource = shift; 
  my $szLocalDestination = shift; 
  my $szFileName = shift;

  if ( ! -f "$szLocalDestination/$szFileName" ) { 
    cd $szLocalDestination; wget $szHttpBaseSource/$szFileName; 
  }
}

#---------------------------------------------------------------------
#------------------------
sub GetAndDeployModuleTgz { 
  my $szPuppetPackageName = shift;
  my $szPuppetModuleName = shift;

  GetFile($f_szHttpBaseSourcePuppet, $f_szLocalDestination, "$szPuppetPackageName.tar.gz");

  if ( ! -e "/etc/puppet/modules/$szPuppetModuleName" ) {
    print "III Installing the $szPuppetPackageName module.\n"; 
    cd /etc/puppet/modules; tar -zxf $f_szLocalDestination/${szPuppetPackageName}.tar.gz; 
    cd /etc/puppet/modules; ln -s $szPuppetPackageName $szPuppetModuleName; 
  }
} 

Error: Evaluation Error: Error while evaluating a Resource Statement, Invalid resource type file_line at /root/install_ntp.pp:10:1 on node localhost