how to leave PR reviews - hackforla/tdm-calculator GitHub Wiki

How to leave PR reviews

  1. go to hackforla/tdm-calculator/Pull requests

image

  1. find and click on your PR you want to review.

image

  1. click on "files changed" after familiarizing yourself using the conversations.

image

  1. below is an example of what you will see:

image

  1. hover over any line you wish to comment on, a blue box with a white plus inside will appear.

This can be done to both the original code on the left and the changed code on the right.

image

  1. after you click the blue button, a window will pop up. Here you can 1. write, 2. preview, 3. add a single comment, or 4. start a review.

image

  1. we are only interested in leaving comments at the moment, so write, review, then press "add a single comment" (3 in the last image)

image

  1. as you can see, it's very visible and easy for others to see. Now others can 1. reply or 2. resolve the conversation to end it

I'll do both for this tutorial

image

  1. now there are 2 conversations. We can expand them by clicking "show resolved"

image

  1. after we expand them, we can also unresolve a conversation.

image