PR Reviews - grommet/grommet GitHub Wiki

PR Review Guidelines

Labels

The waiting label indicates we are waiting for the submitter to respond, these are a lower priority for review. The waiting label should be removed once feedback or review comments are accommodated. (Please mind that the author of the PR may not have permissions to remove labels, so the responsibility for removing waiting labels is on the Admins)

The needs attention label indicates that we should consider taking it overdue to inactivity for too long a time yet something we would like to get.

No flag/label indicates that it should be reviewed, these are a higher priority for review.

General

Try to assign yourself as a reviewer for PRs so it will help others know you have been starting to review it.

As you finish reviewing either "Approve" the PR or drop comments with action items.