Grails Engineering Meeting Notes (10 15 2020) - grails/grails-core GitHub Wiki

Date: 10/15/2020

Attendees

  • Puneet Behl
  • James Kleeh
  • Bobby Warner
  • Jason Schindler

Agenda

  • Moving JFrog Cloud Outage Notification from Grails Slack development channel to some other channel.
  • Support Liquibase 4.0.0 in the Grails Liquibase plugin
  • Current Development Activities
  • Open Discussion

Moving JFrog Cloud Outage Notifications

  • Puneet: I Would like to move JFrog Notifications from development channel to some other channel
    • James: I am fine with that
    • Puneet will reach out to other people in the chat to get their feedback

Support for Liquibase 4 in the Grails Liquibase Plugin

  • Puneet: I would like to add support for Liquibase 4 in the Grails Liquibase Plugin
  • Puneet: Asked for opinions regarding priority of that against other Grails releases
  • James: Liquibase updates are usually problematic because we use it in a way that isn't standard
  • Bobby: Would like to echo James that issues usually occur when updating Liquibase not needed for Grails 4.1
  • Bobby: Would prioritize Spring and Spring Security updates over Liquibase
  • Bobby: Is the Micronaut plugin similar?
  • James: The Micronaut configuration is much simpler.
  • Puneet: Can we use the Micronaut Configuration instead of the Grails Plugin
  • James: You might be able to include it and re-use some of that functionality but the configuration options would change
  • Puneet: Is it OK to do that in a major release?
  • James: We just have to weigh the pros and cons. Is the benefit worth the cost to the users
  • Puneet: In the last meeting we talked about using more Micronaut configurations
  • James: One thing we could do in Grails, is replace the configuration in Micronaut with one that has Grails keys

Current Development Activities

Puneet

  • James Hardwig is about to put in a PR for some Grails GraphQL features
  • Working on fixing some issues in GORM.
    • Recent fix of injecting GORM data services introduced other issues
    • Issue regarding auto timestamping
  • Preparing for 2GM town hall meeting
  • Behind release of Grails 4.0.5 for this week and is pushing it to the middle of next week
  • Offered to work with Bobby on Spring Security updates
  • Also did some cleaning up issues in Grails Core that were not valid
  • Not sure what to do about this issue: https://github.com/grails/grails-data-mapping/issues/1381
    • James: It seems like a hibernate thing. They do bytecode manipulation
    • Bobby: Would like to know if he can reproduce this in a modern Grails app? We can't troubleshoot this otherwise
    • Bobby: Stacktrace is all Hibernate

Bobby

  • Would like to get Grails Security updated before next release
  • There is a recent PR in Grails Core that needs a response: 11626
    • Puneet: I had asked David to take a look at this
  • There are a few old PRs that should be closed or at least addressed. 11146 is from 2 years ago.
    • In general a good way to increase contributions is to respond to these older PRs
  • What do we do with all of these dependabot PRs?
    • Puneet: I usually wait until bugfixes are done and then merge those PRs before release