Firedrake meeting 2024 11 27 - firedrakeproject/firedrake GitHub Wiki
Date and time 2024-11-27 1600 UTC
Action Items
- Pick Chair and Minuter (CW to pick)
- ALL: (ongoing) triage the open issues and confirm if they are indeed still open (and perhaps provide labels)
- CW (formerly JB): Move PyOP2 and TSFC to firedrake and move FInAT to FIAT
- ALL: do things with SV's branches
- DH: Email to Andreas to have 2 (+ others!!!) loopy PRs merged TODO: FIND OUT WHICH PRS THESE ARE
- DH: Get Firedrake a docker open source account (link here)
- DH: Talk to GregVernon about PR#2116.
- JB: Enable merge queues (minutes)
- LC: Try to merge RNH' PR: Movable VOM
- ANY: Add Python 3.13 to PyOP2, TSFC, FIAT, FInAT CI (and others?)
- PB: Profile and speed up some tests (minutes, minutes)
- RK: sort out Firedrake USA details and website before Christmas time
- CW: tackle Loopy warnings
Agenda
Present: DH, DD, PB, CW, IM, FA, LC, JHC, KS
Apologies:
https://github.com/firedrakeproject/firedrake/pull/3817)
CW: Big PyOP2 merge (Everything is addressed. This should be ready to go.
Some people have tested firedrake-update.
Merged.
https://github.com/firedrakeproject/firedrake/pull/3881)
CW: Mac runners (CW: This is very close.
CW: Some tests fails; need to ask Tim to do things.
PB: Slow tests
After some profiling, it seems that the main bottlenecks are related to the loopy linearize
warnings:
On top of this, compilation of zany elements is slow mainly due to gem.optimise.aggressive_unroll
https://github.com/FInAT/FInAT/blob/d3a9b536233870d8853a6162c4112b07689fcdc1/finat/physically_mapped.py#L277
Simply removing aggressive_unroll
brings compilation time for the Johnson-Mercier Riesz map from 32 seconds down to 5.5 seconds.
PB: M is sparse -> need aggressive_unroll.
TSFC: make linearise faster
FInAT: Only use a single Node for M, instead of many.
AdjFloat
in recompute FloatOperatorBlock
and check the control OverloadType
at rf.__call__
DD: Return (https://github.com/dolfin-adjoint/pyadjoint/pull/181) + (https://github.com/firedrakeproject/firedrake/pull/3890)
Very close to be merged.
Merge PRs
Note that PRs put in this section should either be trivial or already have been reviewed. Discussion-worthy PRs should be separate agenda items.
PB: #3436.
Just need some documentation.
PB: #3868
DD: #180 Fix checkpointing for MixedCheckpointSchedules
(Pyadjoint)
Date of next meeting
1600 UTC 2024-12-04