.pr_agent_accepted_suggestions - ether/etherpad-lite GitHub Wiki

The Home button in pad_editbar redirects to window.location.origin + '/', which breaks installations served from a subpath (e.g. /etherpad) by sending users to the domain root.

The client already computes and uses a base path for subpath hosting (see padBootstrap.js setting pad.baseURL/plugins.baseURL).

• src/static/js/pad_editbar.ts[352-360]

Update the Home command to navigate to the Etherpad base path, not the origin root. Prefer an absolute, normalized URL to keep WebKit happy while preserving any prefix, e.g.:

• window.location.href = new URL('..', window.location.href).href; when on /.../p/<padId>
• or window.location.href = new URL('../..', window.location.href).href; (if you want to mirror the previous behavior exactly) Choose the relative target that resolves to the Etherpad homepage for pad URLs, including when Etherpad is hosted under a reverse-proxy prefix.

AGENTS.MD states Node.js >=20.0.0, but README.md and src/package.json indicate Node.js >=18.18.2 while the root package.json enforces >=20.0.0. This creates conflicting guidance and can cause contributor setup failures.

The repo currently has multiple stated Node minimums. AGENTS.MD should not add another competing requirement; it should either align with the project-wide requirement or clearly explain why different parts of the repo have different engine constraints.

• AGENTS.MD[8-11]
• README.md[101-114]
• package.json[44-46]
• src/package.json[125-129]

AGENTS.MD references a non-existent/inaccurate easysync documentation path (doc/easysync/). The easysync materials in this repository live under doc/public/easysync/.

This is onboarding-critical documentation; wrong paths cause contributors to waste time when touching Easysync.

• AGENTS.MD[51-53]

README no longer specifies a minimum Node.js version, but the repo enforces Node >= 20.0.0 at install time (engineStrict) and at runtime (startup exits if Node is too old). This mismatch will cause avoidable setup failures for new users.

• Root package.json sets engines.node to >=20.0.0 and engineStrict: true.
• src/node/server.ts enforces the minimum based on src/package.json.

• README.md[101-105]
• package.json[44-52]
• src/package.json[125-129]

AGENTS.MD says HTML should be indented with 4 spaces, but .editorconfig enforces indent_size=2 for all files. EditorConfig-aware tools will format HTML with 2 spaces, leading to inconsistent formatting and PR churn.

CONTRIBUTING.md also says HTML is 4 spaces, so the inconsistency likely predates this PR; however, adding AGENTS.MD amplifies the mismatch. Decide which rule is correct and make the documentation and tooling consistent.

• AGENTS.MD[30-33]
• .editorconfig[1-20]
• CONTRIBUTING.md[83-90]

AGENTS.MD claims a repo-root tests/ directory, but tests are located under src/tests/ (repo-root path). Some scripts use tests/... paths relative to src/, which is easy to misinterpret.

Contributors reading AGENTS.MD from the repo root will likely search for ./tests and not find the test documentation.

• AGENTS.MD[17-26]

After bumping core’s Node requirement to >=20, the plugin checker still stamps plugins with engines.node >=18.0.0, which is inconsistent with the runtime users will actually run plugins under. This is likely to confuse plugin authors and create avoidable incompatibility reports.

• Core requires Node >=20 (root and src package manifests; CI matrix).
• bin/plugins/checkPlugin.ts currently writes >=18.0.0 into plugin package.json.

• bin/plugins/checkPlugin.ts[229-233]
• package.json[44-46]
• src/package.json[125-129]

AGENTS.MD references a non-existent/inaccurate easysync documentation path (doc/easysync/). The easysync materials in this repository live under doc/public/easysync/.

This is onboarding-critical documentation; wrong paths cause contributors to waste time when touching Easysync.

• AGENTS.MD[51-53]

AGENTS.MD describes the test stack as primarily Vitest, but the default backend test runner is Mocha.

Contributors may attempt to use Vitest for backend tests and fail to run the actual CI-equivalent suite.

• AGENTS.MD[8-16]

AGENTS.MD states Node.js >=20.0.0, but README.md and src/package.json indicate Node.js >=18.18.2 while the root package.json enforces >=20.0.0. This creates conflicting guidance and can cause contributor setup failures.

The repo currently has multiple stated Node minimums. AGENTS.MD should not add another competing requirement; it should either align with the project-wide requirement or clearly explain why different parts of the repo have different engine constraints.

• AGENTS.MD[8-11]
• README.md[101-114]
• package.json[44-46]
• src/package.json[125-129]

AGENTS.MD claims a repo-root tests/ directory, but tests are located under src/tests/ (repo-root path). Some scripts use tests/... paths relative to src/, which is easy to misinterpret.

Contributors reading AGENTS.MD from the repo root will likely search for ./tests and not find the test documentation.

• AGENTS.MD[17-26]