Contributing - domits1/Domits GitHub Wiki
For evaluating external contributions, we look at:
- commit email address(es)
- commit message(s)
- related change(s)
- intend of commit(s)
- source and target branch (acceptance)
- check difference with new target branch
- final evaluation: Reject/RequestingChanges/Accept
E.g. PR: https://github.com/domits1/Domits/pull/1513
- Signed-off-by: Jens Oliver Meiert [email protected]
- message: "refactor: compress images (losslessly, with Imagemin Guard)"
- Imagemin Guard is a library, Jens is maintaining: https://www.npmjs.com/package/@j9t/imagemin-guard
- only image files are changed, and reduced in file size
- intention seems to promote his library
- Jens wants to merge to main, I changed that to acceptance, which gives a difference of 50 commits
- evaluation: Accept
Please thank and express appreciation to the contributor.