Pulls and Commits - deliciousmods/1956_beta GitHub Wiki

Commits

1. To simplify pull request checking, use your own branches whenever making significant content changes, avoid using the bugfix branch or other people's branches.
2. Periodically update from the main Beta-Edits branch to ensure that your branch stays compatible. Failing to do so can cause file conflicts.
3. ALWAYS run debug before asking for a pull and clear all of your errors. Pulls with errors in them will no longer be accepted.
4. If you are having problems solving certain bugs or errors, ask for help.

Pulls

1. When pulling, you can request a direct review from someone specific in GitHub. If not that, then marijn211 will review, who may ask others to check when inactive or when the pull request has content of an unfamiliar topic.
2. A reviewer MUST run the proposed pull first before accepting to check for bugs, errors, and other issues. Just staring at the code can only do so much, especially for large pulls.
3. If there are bugs or errors, post the information in a comment on the pull request.
4. Only accept a pull once the logs are clear.