Pulls and Commits - deliciousmods/1956_beta GitHub Wiki

Commits

  1. Always be sure to commit to your own personal branch. Do not commit to anyone else's branch or the main branch.
  2. Periodically version-check against the main beta_branch to ensure that your branch stays compatible. Failing to do so can cause file conflicts.
  3. ALWAYS run debug before asking for a pull and clear all of your errors. Pulls with errors in them will no longer be accepted.
  4. If you are having problems solving certain bugs or errors, ask for help.
  5. Do not merge commits that do not belong to you. Only commit or merge your own stuff!

Pulls

  1. When pulling, you can request a direct review from someone specific in GitHub. If not that, then either Greatexperiment, SpicyAlfredo, or JudgeAlfred will review.
  2. A reviewer MUST run the proposed pull first before accepting to check for bugs, errors, and other issues. Just staring at the code can only do so much, especially for large pulls.
  3. If there are bugs or errors, post the information in a comment on the pull request.
  4. Only accept a pull once the logs are clear.