tmc meeting minutes 20220512 - deegree/deegree3 GitHub Wiki

TMC Meeting Minutes / Codesprint at Linux Hotel Essen 2022-05-12 - 2022-05-14

Part 1

(09:55) <tfr42>hi
(09:55) <copierrj>hi tfr42
(09:55) <StephanR>Hi
(09:57) - stenger joined
(10:00) <tfr42>https://github.com/deegree/deegree3/pull/1332
(10:01) - JulianZilz joined
(10:01) <copierrj>+1
(10:01) <StephanR>+1
(10:02) - LynG joined
(10:02) <tfr42>+1
(10:02) <JulianZilz>+1
(10:02) - stenger53 joined
(10:02) - stenger53 quit (Client Quit)
(10:03) <StephanR>merged
(10:03) - stenger7 joined
(10:03) - stenger quit (Ping timeout: 252 seconds)
(10:03) <StephanR>https://github.com/deegree/deegree3/pull/1330
(10:03) - stenger7 quit (Client Quit)
(10:03) - stenger joined
(10:04) <StephanR>+1
(10:12) - stenger15 joined
(10:13) - stenger quit (Ping timeout: 252 seconds)
(10:15) <copierrj>+1
(10:17) <tfr42>+1
(10:17) <stenger15>+1
(10:18) - Paul9 joined
(10:18) <JulianZilz>+1
(10:18) <copierrj>merged
(10:18) <tfr42>JDK 11 build job https://buildserver.deegree.org/view/misc/job/deegree-3.4/job/deegree-3.4-openjdk11/
(10:19) <tfr42>git clone https://github.com/lat-lon/deegree3.git
(10:19) <tfr42>git switch java11-857
(10:29) - stenger15 quit (Ping timeout: 252 seconds)
(10:33) - stenger joined
(10:33) <tfr42>PR merged into master so far: 20
(10:33) <tfr42>https://github.com/deegree/deegree3/pulls?q=is%3Apr+is%3Amerged+merged%3A%3E%3D2022-05-12
(10:34) <tfr42>Proposing to build a release for JDK 1.8
(10:34) <tfr42>Bugfix Version 3.4.31
(10:34) <stenger>+1
(10:34) <tfr42>+1
(10:34) <copierrj>+1
(10:35) <StephanR>+1
(10:41) <stenger>https://github.com/deegree/deegree3/pull/661
(10:42) <stenger>The following pull requests are about schema changes and will merged into version 3.5. However, now, we are just voting, the merges are done later.
(10:42) <stenger>https://github.com/deegree/deegree3/pull/661
(10:42) <StephanR>+1
(10:42) <copierrj>+1
(10:42) <tfr42>+1
(10:42) <stenger>+1
(10:43) <stenger>https://github.com/deegree/deegree3/pull/700
(10:44) <copierrj>+1
(10:44) <StephanR>+1
(10:44) <tfr42>+1
(10:45) <stenger>+1
(10:45) <stenger>https://github.com/deegree/deegree3/pull/722
(10:46) <tfr42>+1
(10:47) <stenger>+1
(10:48) <StephanR>+1
(10:49) <copierrj>+1
(10:50) <StephanR>https://github.com/deegree/deegree3/pull/726
(10:50) <stenger>https://github.com/deegree/deegree3/pull/726
(10:50) <copierrj>+1
(10:50) <StephanR>+1
(10:50) <tfr42>+1
(10:50) - stenger45 joined
(10:50) <stenger45>+1
(10:51) <stenger45>https://github.com/deegree/deegree3/pull/779
(10:51) <copierrj>+1
(10:52) <stenger45>+1
(10:52) <tfr42>+1
(10:52) <StephanR>+1
(10:53) <stenger45>https://github.com/deegree/deegree3/pull/941
(10:54) - stenger quit (Ping timeout: 252 seconds)
(10:56) <tfr42>+1
(10:56) <stenger45>+1
(10:56) <copierrj>+1 (when Jenkins is happy about it)
(10:57) <StephanR>+1 after fixing the build
(10:58) <stenger45>https://github.com/deegree/deegree3/pull/971
(10:59) <tfr42>+1
(11:01) <StephanR>+1
(11:01) <stenger45>+1
(11:02) <copierrj>+1
(11:02) <stenger45>https://github.com/deegree/deegree3/pull/1003
(11:04) <stenger45>+1
(11:04) <copierrj>+1
(11:04) <tfr42>+1
(11:05) <StephanR>+1
(11:05) <stenger45>https://github.com/deegree/deegree3/pull/1005
(11:15) <stenger45>+1
(11:16) <copierrj>+1
(11:16) <StephanR>+1
(11:16) <tfr42>+1
(11:16) <stenger45>https://github.com/deegree/deegree3/pull/1039
(11:23) - stenger45 quit (Ping timeout: 252 seconds)
(11:25) <JulianZilz>+1
(11:28) <tfr42>+1
(11:28) <StephanR>+1 would be nice to have a more specific description in the documentation
(11:28) <copierrj>+1
(11:28) - stenger joined
(11:29) <JulianZilz>https://github.com/deegree/deegree3/pull/1022
(11:33) <tfr42>This PR requires that existing workspace configurations need to be updated
(11:34) <tfr42>The deegree administration console is broken and not capable to apply the necessary changes
(11:34) <stenger>https://github.com/deegree/deegree3/pull/1042
(11:39) <copierrj>+1
(11:39) <stenger>+1
(11:39) <tfr42>+1
(11:39) <StephanR>+1 needs copyright header
(11:40) <stenger>https://github.com/deegree/deegree3/pull/1055
(11:42) <StephanR>+1 needs copyright header
(11:44) <LynG>added
(11:46) <stenger>+1
(11:46) <StephanR>thx, +1
(11:47) <copierrj>+1
(11:47) <tfr42>+1
(11:49) <stenger>https://github.com/deegree/deegree3/pull/1085
(11:53) <copierrj>+1
(11:53) <StephanR>+1
(11:53) <tfr42>+1
(11:54) <stenger>+1
(11:55) <stenger>https://github.com/deegree/deegree3/pull/1087
(11:56) - jmckenna joined
(12:00) - stenger quit (Ping timeout: 252 seconds)
(12:08) - stenger joined
(12:10) <StephanR>as commented on the pr this will be postponed
(12:11) <stenger>https://github.com/deegree/deegree3/pull/1200
(12:13) <copierrj>+1
(12:13) <StephanR>+1
(12:13) <stenger>+1
(12:13) <tfr42>+1
(12:14) <stenger>https://github.com/deegree/deegree3/pull/1201
(12:16) <StephanR>+1
(12:16) <copierrj>+1
(12:16) <tfr42>+1
(12:16) <stenger>+1
(12:16) <stenger>https://github.com/deegree/deegree3/pull/1205
(12:19) <stenger>+1
(12:19) <copierrj>+1
(12:20) <StephanR>+14 after rebasing onto #1330
(12:20) <StephanR>+1 after rebasing onto #1330
(12:20) <tfr42>+1
(12:20) <stenger>https://github.com/deegree/deegree3/pull/1231
(12:24) <copierrj>needs rebase
(12:27) <StephanR>+1 after rebase
(12:30) <tfr42>let's postpone it for now
(12:30) - stenger82 joined
(12:30) - stenger quit (Ping timeout: 252 seconds)
(12:33) - stenger82 quit (Client Quit)
(12:33) <copierrj>+1
(12:33) - stenger joined
(12:33) <stenger>+1
(12:33) <stenger>+1
(12:34) <tfr42>+1 with requested changes
(12:35) <stenger>https://github.com/deegree/deegree3/pull/1238
(12:37) <copierrj>+1
(12:37) <stenger>+1
(12:37) <StephanR>+1
(12:38) <stenger>https://github.com/deegree/deegree3/pull/1285
(12:40) <copierrj>+1
(12:40) <stenger>+1
(12:40) <tfr42>+1
(12:40) <StephanR>+1
(12:45) <tfr42>The following PR are ready to be merged into the upcomming version 3.5
(12:45) <tfr42>https://github.com/deegree/deegree3/pulls?q=is%3Apr+is%3Aopen+label%3A%22schema+change%22+milestone%3A3.5+label%3Aready
(12:45) <tfr42>Next step is to prepare a branch with those PR based on the current master branch
(12:57) <StephanR>This is a example what would be changed on the schemas https://github.com/deegree/deegree3/compare/master...gritGmbH:schema/example-of-schema-migration
(12:57) - stenger5 joined
(12:57) <StephanR>See changes in this commit: https://github.com/deegree/deegree3/commit/e24b83c70180e83e3e08420e71481e34a9a1e81b
(12:58) - stenger quit (Ping timeout: 252 seconds)
(13:00) <StephanR>Updated the commit: https://github.com/deegree/deegree3/commit/b2da24ef4b967f97965896e0647825424ee79ab4
(13:05) - tfr42 quit (Ping timeout: 248 seconds)
(13:06) - JulianZilz quit (Ping timeout: 252 seconds)
(13:28) - Paul9 quit (Ping timeout: 252 seconds)
(14:02) - stenger5 quit (Ping timeout: 252 seconds)
(14:04) - tfr42 joined
(14:09) - tfr42 quit (Ping timeout: 260 seconds)
(14:11) - tfr42 joined
(14:39) - JulianZilz joined
(14:51) - stenger joined
(15:00) <StephanR>In Theory a new build job would be required for:
(15:00) <StephanR>- uncoupled\deegree-jaxb-resolver
(15:00) <StephanR>- uncoupled\deegree-jaxb-util (maybe)
(15:08) - darkblueb joined
(15:37) <tfr42>docker image with v3.4.31 pushed to hub.docker.com
(15:37) <tfr42>v3.4.31: digest: sha256:e344cc214b2224d56d413a303072e478416e8df9ea41d6985033ff07ae3ca2a7 size: 2421
(15:40) <stenger>New pull request was created to clean up Maven build: https://github.com/deegree/deegree3/pull/1333
(15:50) <tfr42>regarding the proposed changes on the schema handling will result in
(15:51) <StephanR>How do we change the schema for configVersion
(15:51) <StephanR>currently variant of this is used:
(15:51) <StephanR><attribute name="configVersion" use="required">
(15:51) <StephanR> <simpleType>
(15:51) <StephanR> <restriction base="string">
(15:51) <StephanR> <enumeration value="3.4.0" />
(15:51) <StephanR> <enumeration value="3.0.0" />
(15:51) <StephanR> </restriction>
(15:51) <StephanR> </simpleType>
(15:51) <StephanR> </attribute>
(15:51) <tfr42>- the URI for a XSD will be https://schemas.deegree.org/3.5/{resource}
(15:52) <tfr42>- a symbolic link will exist to point to the latest version, e.g. 3.5.1
(15:53) <tfr42>- the XSD attribute "configVersion" will be optional and of type "any"
(15:54) <copierrj>+1
(15:54) <stenger>+1
(15:54) <StephanR>+1
(15:54) <tfr42>+1
(15:58) <StephanR>So the new definition will be <attribute name="configVersion" type="string" use="optional"> ?
(16:36) <copierrj>i've manually merged all schema changes we agreed on this morning: https://github.com/deegree/deegree3/tree/config_schema_changes
(16:41) <copierrj>config_schema_changes branch build (including integration tests) succeeded locally
(16:57) <copierrj>just added another merge commit to config_schema_changes
(16:59) <stenger>GDAL 3.0: Testing with Debian 11 was not possible: https://github.com/deegree/deegree3/pull/1265
(17:03) - stenger quit (Ping timeout: 252 seconds)
(17:50) - Tenchi[m] joined
(17:50) - stenger joined
(18:05) - copierrj quit (Quit: Client closed)
(18:05) <StephanR>[18:03:55] INFO: [DeegreeWorkspaceUpdater] Workspace change
(18:05) <StephanR>java.lang.NoSuchMethodError: org.deegree.commons.ows.metadata.DatasetMetadata.<init>(Ljavax/xml/namespace/QName;Ljava/util/List;Ljava/util/List;Ljava/util/List;Ljava/util/List;Ljava/util/List;Ljava/util/List;Ljava/util/List;Lorg/deegree/commons/ows/metadata/layer/Attribution;)V
(18:05) <StephanR> at org.deegree.services.wms.controller.capabilities.theme.DatasetMetadataFactory.buildDatasetMetadata(DatasetMetadataFactory.java:108)
(18:05) <StephanR> at org.deegree.services.wms.controller.capabilities.theme.WmsCapabilities130ThemeWriter.writeTheme(WmsCapabilities130ThemeWriter.java:134)
(18:05) <StephanR> at org.deegree.services.wms.controller.capabilities.Capabilities130XMLAdapter.writeThemes(Capabilities130XMLAdapter.java:203)
(18:05) <StephanR> at org.deegree.services.wms.controller.capabilities.Capabilities130XMLAdapter.writeCapability(Capabilities130XMLAdapter.java:195)
(18:05) <StephanR> at org.deegree.services.wms.controller.capabilities.Capabilities130XMLAdapter.export(Capabilities130XMLAdapter.java:162)
(18:12) - stenger quit (Ping timeout: 252 seconds)
(20:13) - darkblueb quit (Read error: Connection reset by peer)
(20:13) - darkblueb joined
(21:21) <tfr42>https://github.com/deegree/deegree3/issues/1334
(21:28) <JulianZilz>A change was suggested in the ticket.

Part 2

Part 3

Part 4

(10:52) <StephanR>Hi
(10:52) <tfr42>hi
(10:52) - LynG joined
(10:54) - LynG quit (Client Quit)
(11:07) <StephanR>Question is there a library available in your dev env for ${java.home}/lib/rt.jar ?
(11:07) <StephanR>And also which exact version of java11 do you use for develpment ?
(11:08) - LynG joined
(11:08) <StephanR>Question is there a library available in your dev env for ${java.home}/lib/rt.jar ?
(11:09) <StephanR>And also which exact version of java11 do you use for develpment ?
(11:10) - jmckenna quit (Ping timeout: 260 seconds)
(12:18) - jmckenna joined
(12:37) <StephanR>Vote for https://github.com/deegree/deegree3/pull/1333
(12:37) <LynG>+1
(12:37) <StephanR>+1
(12:38) <tfr42>+1
(12:39) <StephanR>merged manually into branch config_schema_changes
(12:52) <tfr42>Build job https://buildserver.deegree.org/job/deegree-3.4-master/ switched to Maven 3.8
(14:54) <StephanR>Proposal for next steps:
(14:54) <StephanR>1) change buildserver to reflect change of default branch
(14:54) <StephanR> - change view deegree-3.4 with (regex deegree-3.4.)
(14:54) <StephanR> - move all deegree-3.4 jobs to folder deegree-3.4
(14:54) <StephanR> - move open-pull-request to main folder
(14:54) <StephanR> - disable deegree-3.4-pipeline
(14:54) <StephanR> - copy deegree-3.4-master to deegree-3.5-release (classic maven build-job only for releases)
(14:54) <StephanR> - copy deegree-3.4-documentation to deegree-3.5-publish (documentation, apidoc, schemas)
(14:54) <StephanR>2) create branch 3.4-main from current master
(14:54) <StephanR>3) rename master to main (this will automaticall change the branch to main)
(14:54) <StephanR>4) change version of config_schema_changes to 3.5.0-SNAPSHOT
(14:54) <StephanR>5) Create Pull-Request for config_schema_changes and merge into main
(14:54) <StephanR>Please give your vote
(14:55) <tfr42_>+1
(14:55) <LynG>+1
(14:55) <StephanR>+1
(15:14) <StephanR>Proposal to cleanup the stale branche feature/gml-temporal-support by remoiving it as the changes were already merged ?
(15:14) <StephanR>+1
(15:14) <tfr42_>+1
(15:17) <LynG>+1
(15:18) <StephanR>Proposal to cleanup the stale branch revert-400-jrcportal-1723-resourceHandling-ISOMetadataStore as the changes are now obsolete (as reviewed) ?
(15:18) <StephanR>+1
(15:18) <tfr42_>+1
(15:18) <LynG>+1
(15:40) <tfr42_>https://github.com/deegree/deegree3/pull/1335
(15:40) <tfr42_>merged into main
(15:54) <tfr42_>https://github.com/deegree/deegree3/pull/1336
(15:54) <StephanR>+1
(15:54) <tfr42_>+1
(15:54) <LynG>+1
(16:00) <StephanR>Rebased version of commons-dbcp2 upgrade in PR https://github.com/deegree/deegree3/pull/1337
(16:07) <tfr42_>+1
(16:07) <StephanR>+1
(16:07) <LynG>+1
(16:07) <StephanR>merged
(16:09) <tfr42_>https://github.com/deegree/deegree3/pull/1265
(16:09) <LynG>+1
(16:09) <tfr42_>+1
(16:09) <StephanR>+1
(16:09) <tfr42_>merged
(16:09) <StephanR>https://github.com/deegree/deegree3/pull/1287
(16:12) <StephanR>+1
(16:12) <tfr42_>+1
(16:12) <LynG>+1
(16:13) <tfr42_>merged
(16:13) - LynG quit (Quit: Client closed)
(17:01) <tfr42_>Duplicate classes found:
(17:01) <tfr42_> Found in:
(17:01) <tfr42_> org.slf4j:jcl-over-slf4j:jar:1.7.36:compile
(17:01) <tfr42_> commons-logging:commons-logging:jar:1.2:compile
(17:52) <tfr42_>https://github.com/deegree/deegree3/pull/1338
(17:55) <tfr42_>+1
(18:00) <StephanR>+1
(18:01) <tfr42_>merged
(18:08) - jmckenna quit (Ping timeout: 240 seconds)
(18:53) <tfr42_>https://github.com/deegree/deegree3/pull/1339
(18:53) <tfr42_>+1
(18:53) <StephanR>+1
(18:53) <tfr42_>merged
(18:55) - jmckenna joined
(18:59) <StephanR>Should we build a release for deegree-jaxb-resolver as version 1.1 ?
(18:59) <StephanR>+1
(18:59) <tfr42_>+1
(18:59) - jmckenna quit (Ping timeout: 252 seconds)
(18:59) <tfr42_>release job started https://buildserver.deegree.org/view/misc/job/internal/job/jaxb-resolver/
(19:10) <StephanR>related pr https://github.com/deegree/deegree3/pull/1340
(19:11) <tfr42_>+1
(19:11) <StephanR>+1