TMC Meeting Minutes 2020-12-17

(17:06) - tfr42 joined
(17:06) <stenger>https://meet.google.com/nja-kfbc-xkg
(17:06) <tfr42>hi
(17:06) <StephanR>Hi
(17:06) <StephanR>https://meet.google.com/nja-kfbc-xkg
(17:08) <copierrj>https://github.com/deegree/deegree3/pull/1104
(17:09) <stenger>https://github.com/deegree/deegree3/pull/1106
(17:10) <StephanR>https://github.com/deegree/deegree3/pull/1084
(17:10) <StephanR>https://github.com/deegree/deegree3/pull/1086
(17:14) <tfr42>https://github.com/deegree/deegree3/pull/1107
(17:16) <tfr42>https://github.com/deegree/deegree3/pull/1032
(17:18) <tfr42>https://github.com/deegree/deegree3/issues/1072 was the issue about the growing size of each integration build
(17:19) <stenger>https://github.com/deegree/deegree3/pull/1101
(17:20) <tfr42>https://github.com/deegree/deegree3/pull/931
(17:21) <copierrj>lets start at the top:
(17:21) <copierrj>https://github.com/deegree/deegree3/pull/1104
(17:27) <tfr42>is linked to https://github.com/deegree/deegree3/pull/1092
(17:49) <stenger>https://portal.opengeospatial.org/files/?artifact_id=74183&version=2
(17:49) <stenger>The corrected GML 3.2 schema is available at http://schemas.opengis.net/gml/3.2.1/. Note that the use of “3.2.1” in the URL is unchanged since this version (3.2.2)is a corrigendum and the corrected schema replaces the GML 3.2.1 schema.Previous versions of the GML 3.2.1 schema are available at
(17:50) <stenger>http://schemas.opengis.net/gml/gml-3_2_1.zip.
(17:50) <stenger>The change to the gml:id attribute reverts a change that has been made between GML 3.1.1 and GML 3.2.1. Reverting this change also addresses comments raised by several communities since the release of GML 3.2.1 / ISO 19136:2007. As the correction relaxes a constraint in the XML schema, not all instance documents created based on
(17:50) <stenger>the GML 3.2.2 schema will be valid against the GML 3.2.1 schema:•all GML 3.2 instance documents that include a gml:id attribute on a ring or shell element are not valid against the GML 3.2.1 schema;•all GML 3.2 instance documents that include a feature, a spatial object or a temporal object without a gml:id
(17:50) <stenger>attribute are not valid against the GML 3.2.1 schema.
(18:00) <copierrj>https://github.com/deegree/deegree3/blob/a492075be71b9d54c37b47b0bb3982aa42684af3/deegree-core/deegree-core-base/src/main/java/org/deegree/gml/GMLVersion.java#L62
(18:00) <copierrj>https://github.com/deegree/deegree3/blob/a492075be71b9d54c37b47b0bb3982aa42684af3/deegree-core/deegree-core-base/src/main/java/org/deegree/gml/GMLVersion.java#L142
(18:08) <StephanR>https://github.com/deegree/deegree3/pull/1104/files#diff-dc75ad421f24b5267e203e6c4d89b72e534f94308c812ae39a45774ba3e5119dR565
(18:13) <StephanR>https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally
(18:15) <copierrj>proposal is to merge https://github.com/deegree/deegree3/pull/1092 and immediately apply some of the changes of https://github.com/deegree/deegree3/pull/1104 manually
(18:15) <stenger>+1
(18:15) <StephanR>+1
(18:15) <copierrj>+1
(18:15) <tfr42>+1
(18:16) <tfr42>I can hear you perfectly
(18:17) <StephanR>Merged #1092
(18:18) <tfr42>Both Build jobs started for pipeline build and classic build to verify the master branch
(18:20) <tfr42>https://github.com/deegree/deegree3/pull/1106
(18:25) <tfr42>https://buildserver.deegree.org/view/misc/job/deegree-3.4/job/pull-request/
(18:26) <tfr42>PR #1106 is still building
(18:27) <tfr42>in case it completes without an error we will accept that PR?
(18:27) <copierrj>+1
(18:27) <tfr42>+1
(18:27) <stenger>+1
(18:27) <StephanR>+1 (in case of a succesfull build)
(18:31) <tfr42>OK marked PR #1106 for merging
(18:32) <copierrj>https://github.com/deegree/deegree3/pull/1108
(18:32) <tfr42>https://github.com/deegree/deegree3/pull/1084
(18:32) <StephanR>Last successfull build 5 days ago http://buildserver.deegree.org/blue/organizations/jenkins/deegree-3.4%2Fpull-request/detail/PR-1084/19/pipeline/55
(18:38) <tfr42>+1
(18:38) <stenger>+1
(18:38) <StephanR>+1
(18:38) <copierrj>-+0
(18:41) <copierrj>https://github.com/deegree/deegree3/pull/1108
(18:41) <StephanR>Merged #1084
(18:44) <StephanR>+1 (if #1108 was built successfully)
(18:45) <stenger>+1
(18:46) <tfr42>+1
(18:46) <stenger>if build is successful
(18:48) <tfr42>https://github.com/deegree/deegree3/pull/1086
(18:50) <copierrj>+1
(18:50) <tfr42>https://buildserver.deegree.org/job/deegree-3.4/job/pull-request/view/change-requests/job/PR-1086/20/ completed sucessfully
(18:50) <tfr42>+1
(18:51) <stenger>+1
(18:51) <StephanR>+1
(18:51) <StephanR>Merged #1086
(18:52) <tfr42>Next is PR #1107
(18:52) <tfr42>https://buildserver.deegree.org/job/deegree-3.4/job/pull-request/job/PR-1107/ is still running
(18:53) <StephanR>https://buildserver.deegree.org/blue/organizations/jenkins/deegree-3.4%2Fpull-request/detail/PR-1107/1/pipeline
(18:54) <StephanR>I think it is good because the build phase ran ok
(18:55) <copierrj>+1
(18:55) <stenger>+1
(18:55) <tfr42>+1
(18:56) <StephanR>+1
(18:56) <StephanR>Merged #1107
(18:57) <copierrj>After a lengthy discussion the TMC decided to make gml ids always optional. Although providing a gml id was mandatory in earlier versions of GML the OGC apparently decided to change the GML standard retroactively.Therefore we decided to merge PR #1092 instead of yours. This change completely removes the gml id check. Some changes you proposed in
(18:57) <copierrj>this PR are however lifted out into PR #1108 in order to support for 3.2.2.
(18:58) <copierrj>.. to add support for 3.2.2.
(18:58) <stenger>+1
(18:58) <StephanR>+1
(18:58) <tfr42>+1
(19:00) <tfr42>https://github.com/deegree/deegree3/pull/1032
(19:02) <tfr42>the previous build was successfull https://buildserver.deegree.org/job/deegree-3.4/job/pull-request/view/change-requests/job/PR-1032/20/
(19:03) <copierrj>+1
(19:03) <tfr42>+1
(19:03) <StephanR>+1
(19:03) <stenger>+1
(19:03) <StephanR>Merged #1032
(19:04) <tfr42>Next PR
(19:04) <tfr42>https://github.com/deegree/deegree3/pull/1101
(19:05) <tfr42>previous build was successfull https://buildserver.deegree.org/job/deegree-3.4/job/pull-request/view/change-requests/job/PR-1101/12/
(19:05) - stenger quit (Remote host closed the connection)
(19:10) <copierrj>+1
(19:10) <tfr42>+1
(19:12) <tfr42>Still under discussion
(19:12) <copierrj>vote change: -1
(19:12) <tfr42>We will comment on that PR that it might miss a case
(19:12) <tfr42>for now
(19:12) <tfr42>-1
(19:16) <StephanR>added a comment related a propsed change
(19:16) <tfr42>https://github.com/deegree/deegree3/pull/931
(19:17) <copierrj>+1
(19:18) <StephanR>+1
(19:19) <tfr42>+1
(19:19) <StephanR>Merged #931
(19:28) <copierrj>https://github.com/deegree/deegree3/pull/1108
(19:29) <tfr42>https://github.com/deegree/deegree3/pull/1106
(19:31) <tfr42>Under the assumption that PR #1108 and #1106 build completes we will release
(19:31) <tfr42>Next version will be 3.4.14
(19:31) <StephanR>ok
(19:31) <tfr42>including the PR merged today
(19:32) <copierrj>+1
(19:32) <tfr42>+1
(19:32) <StephanR>+1
(19:32) <StephanR>https://github.com/deegree/deegree3/issues/1072
(19:38) <tfr42>I would propose to integrate the cleanWS step into the pipeline
(19:41) <tfr42>Release will be published as soon as all jobs as completed successfully
(19:42) <copierrj>next meeting 15th of January 2021?
(19:42) <copierrj>11:00h?
(19:42) <tfr42>+1
(19:42) <copierrj>+1
(19:42) <StephanR>+0 (i may be not available)
(19:44) <copierrj>bye
(19:44) <StephanR>bye
(19:44) - copierrj quit (Remote host closed the connection)