temp‐SerdarBahar - bounswe/bounswe2025group5 GitHub Wiki
Serdar Bahar (Mobile)
1. Responsibilities
Developed core additions to mobile features with test coverage, conducted code reviews. Managed APK generation and co-authored project documentation for Milestone 3.
2. Main Contributions
- Finalization of Voiceover in mobile application
- Integrating report API endpoints, with test coverage and report-type notifications
- Implementing reset password functionality
- Review of important code from other mobile developers
- APK generation, data population for Milestone 3 demo
3. Significant Issues
3.1 Code-Related Issues
- #743 - Voiceover: Finalized VoiceOver and TalkBack support by implementing dynamic accessibility labels and hints, specifically for notification, post interaction, and language choice contexts.
- #798 - Reset Password: Implemented reset password modal in the profile page, rejection of weak passwords (also in register), with test coverage using Jest.
- #809 - Report (API endpoints): Integrated the report API endpoints for posts and comments (report modal was present) with error handling and loading states, with test coverage using Jest
3.2 Non-Code-Related Issues
- #761 - User Experience Assessment (Lab 8): Co-authored user assessment part in Requirements Review and Acceptance Planning document, which was a deliverable in Lab 8.
- #789 - Demo-Data Strategy (Lab 9): Co-authored demo-data strategy part in M3 Demo Strategy document, which was a deliverable in Lab 9.
- #822 - Population of New Images for the New Machine: Updated profile photos of users whose profile picture was not properly transferred from the old deployment machine.
4. Pull Requests
Created by Me
| PR Explanation | PR Link |
|---|---|
| Mobile / Voiceover | #765 |
| Mobile / Report API endpoints | #808 |
| Mobile / Report-type notifications | #840 |
Reviewed-Modified/Merged By Me
| PR Explanation | Action | PR Link |
|---|---|---|
| Mobile / Show impact reconstruction, custom waste logging, reset password functionalities | Implemented reset password functionality, reviewed the rest | #796 |
| Mobile / Search filters | Reviewed, added 2 commits for accessibility improvement, and merged | #806 |
| Mobile / Badges | Reviewed and merged | #802 |
| Backend / Badge triggers | Reviewed and merged | #790 |
| Mobile / Improvements in notification system | Reviewed, added 5 commits for bug resolution and improvement | #758 |