Releases - ariel-fer/Araena GitHub Wiki
[[TOC]]
Included new colors based on style guide provided by Novo. used RGB colors without transparency
Re-organized imports on all files Removed white lines in many parts of the code where it was being used instead of tabs Unlocked cells that are read only before and locked them again after undo and redo.
- On Material ended in 1289, add a few numbers to Stock Adjusted, submit calculations. then do undo and submit them again. you will see table and graph are not properly updated
te comento lo que encontre:
- segun el video que te adjunto, veo que en main ocurre estos problemas igualmente. el problema esta como te explico en que la app no esta detectando luego de un undo y redo cuales son los nuevos cambios a tener en cuenta para mandar al backend.
- esto investigue y es por la implementacion que tiene el undo y redo en tableEditable.html, que algo erroneo hay:
function updateHistory(info, action) {
debugger;
if(!info) {return}
if (action === 'undo') {
if (info.records) {
info.records.forEach(record => {
spreadsheetHistory.pop()
})
}
} else if (action === 'redo') {
if (info.records) {
info.records.forEach(record => {
const coord = `${record.x-colsToSkip}-${record.y}`;
spreadsheetHistory.push(coord);
})
}
} else {
const coord = `${info.colIndex-colsToSkip}-${info.rowIndex}`;
spreadsheetHistory.push(coord)
}
debugger;
}
segun veo en el debugger de abajo de todo, luego de un undo, todo el historial se borra. no se si esto lo saco de algun ejemplo el tipo, pero trate de revisar un poco pero no iba a llegar a tener una solucion para hoy la verdad, y no queria meterme tan de lleno hasta que no lo hables con el primero seguramente.
see videos sent via Slack: https://polyglot-outsourcing.slack.com/archives/D9K694A77/p1746497735015949 https://polyglot-outsourcing.slack.com/archives/D9K694A77/p1746498918525829
- material 1026530 - Actual Stock en 0 al crear un scenario
y respecto a este material y crear un scenario, esto me termino haciendo ver un error que no vi antes:
- como veras en la foto, veo que hasta Mar del año que viene esta todo ok, pero luego es como que no se actualizan esos valores con el Stock Released.
- revise main y eso no pasa.
- termine entendiendo que el problema debe seguir estando con el tema de los read only, porque en el backend la data fluye correctamente, pero a la UI no llega toda la row actualizada sino hasta Marzo. es extraño. el grafico si viene bien.
- me imagino que esto es lo que viste que termina rompiendose de alguna forma al cargar neuvamente el scenario. con estos valores bajos uno se da cuenta mas facil que hay algo raro
- material 1025701: mismo caso, creo scenario, pongo unos datos en stock djusted, lo guardo y luego hago un load y se rompe algo en la tabla
respecto a esto, por lo que veo lo que se rompe son los width de las columnas. ahi no estoy seguro que pasa pero en base al error que tira, que imagino no tiene nada que ver, imagino que algun problema debe haber desde javascript con querer chequear algun elemento que aun no existe y por eso rompe de alguna forma, y cada columna tiene un width diferente en base al default value.
- Blocked first 2 columns with styling, same as the first row
- 2nd Spreadsheet no longer rendered by mistake,
- No more Flickering while updating data in the table.
- Stock Released row readOnly status fixed since it was not allowing the number to be updated upon re-calculations (by modifying Demand Forecast for example).
- Adapted code to work along with the removal of the first 2 columns, adding the first one as freezed
- Material dropdown now has number and name
- All button texts are no longer uppercase.
- Loading an old scenario (old scenario 2 from material 5903101), Now Both Stock Released and Stock Released Original match, even after a data refresh
- Standing out of scenario view, define an MohTarget of 4 years. now loading scenario 'old scenario 2' from material 5903101, which has a predefined MoHTarget of 2 years, once it loads it will show the graph up to 2 years only, but attempting to modify a cell will reveal the MoHTarget of 4 years, extending the graph with blank bars. This could still work but introduced many inconsistencies in data that potentially breaks the app, specially adding now with the addition of the Stock Adjusted.
- Added support for Stock Adjusted in scenarios, both shown as 2nd row in the table and as an orange bar in the graph.
- Stock Adj will be kept along with Demand Forecast when a scenario data is refreshed. previously it was only Demand Forecast.
- Graph bar will only be included if Stock Adj is positive. otherwise the final calculation will be shown as Stock Released in the graph
- Added a row for Stock Released Original, only meant for validation/testing purposes for now.
- Stock Released row now is greyed out for editing.
- Spreadsheet cells now includes thousand separators while user is typing the number.
- Spreadsheet cells now accepts negative numbers, while also blocking any attempts to include any other type of character rather than commas or a single dot for decimals.
Modified tableEdit.py to better show the changes that need to be done for each of the rows being edited. This improves code readability to understand what is going on for each measure.
- The following warning that appears in the backend:
BokehUserWarning: ColumnDataSource's columns must be of the same length. Current lengths: ('Stock Quarantine', 37), ('Stock Released', 37), ('dates', 25)
is now solved using the scenario's own forecast in years
instead of using the one from the filter dropdown.
-
Loading an scenario (old scenario 2 from material 5903101), setting Demand forecast to 0 on the first month, and then refreshing once the data will set Demand Cumulative Sum on that month to 0, but then a new refresh seems to be bringing the old data again and adding that to the Cumulative Sum while the Demand Forecast still is 0.
-
After loading any scenario, attempting to modify demand forecast to 0 will reveal a new calculation for SS Rolling x months. trying to bring back the previous number and applying changes, the number calculated for SS rolling X months will be totally different from the original.
-
While making sure the Filter for MOHTarget is set at 8, loading an scenario (old scenario 2 from material 5903101), row #10 says SS rolling 2 months. after Refreshing the data, the values change there because it also changes to SS rolling 8 months, number that comes from the filter itself even though the scenario shouldn't be taking it from there.
- Loading an old scenario (old scenario 2 from material 5903101), you can see Stock Released is equal to Stock Released original, taking into account if there is Stock Adjusted also. However, when refreshing the data, you can see that Stock Released and Original no longer are equal to each other, even taking Stock Adj into consideration [SOLVED in 2024.04.21]
- After adding Stock Adjusted, the spreadsheet was rendering a 2nd instance after any edits. Code was updated to re-render the spreadsheet after each modification, which makes the component to flash for a second and not show data during that lapse. It is pending to revisit how to properly update the spreadsheet without destroying it after each time. [SOLVED in 2024.04.28]