Contribution Process - adobecom/milo GitHub Wiki
Getting your code to production
- Devs: open PR, 2 developer approvals, green light from PM & Consonant on the PR/Jira as needed, all Github checks pass, assign QE
- QE: apply "Ready for Stage" label after testing
- If the conditions ☝️ pass (reviews, checks, label) the PR will automatically be queued to be merged into Stage
- Once a stage "batch" PR gets created, the batch gets merged on India/EU/US working hours once 4 SOT sign offs are provided & checks are passing
Note: The "queue" is not obvious, but you can investigate the most recent workflow runs to see why your PR was merged or not. If still unsure, reach out to #milo-dev
PR Labels
- Every PR must be tested. QE should apply the 'Ready for Stage' label only after a PR has received approvals, all checks have passed, and testing is complete.
- The 'high impact' label will trigger a message in #milo-community & #milo-changelog for PRs that require additional review from consumers, GWP, design, etc.
- The 'high priority' label will prioritize PRs in the merge queue. Please reserve this label for JIRA BLOCKERS only.
For emergencies, see the separate CSO docs