Tool Chain Assignment - TommyTram/wasp_sw_course GitHub Wiki
Iteration 1 (Getting started)
What was your background expertise on version control systems?
Tommy - 3 years experience
Ivo - 0.5 years experience
Arian - 0 years experience
What tasks were easy?
Writing the base code for the translation was simple.
Were there problems that were difficult to sort out?
Setting up Ant with the build file was a bit of a hassle to understand what every line of xml code does. JUnit was also new, but a bit easier.
What surprised you?
That everything worked smooth and was easier than it seemed at start.
Iteration 2 (Test-Driven Development)
Reflect and discuss briefly what you have done in this iteration.
What went well? Dividing the issues and writing the code seperately.
What would you like to improve or do differently? Make sure everybody pulls, run the junit-tests before commiting.
What surprised you? How easy it was to set up a test.
Iteration 3 (Code review)
Discuss the current design. Is the code clean?
Yes!
Is there a need for larger refactorings?
No!
Do you need to agree on some design issues or coding conventions?
We have already agreed upon this before starting the project!
What went well?
working in separate branches and different possible solutions. We then had a discussion to choose the best implementation and chose the best algorithm and made a pull request.
What would you like to improve or do differently?
Maybe we should have each created a feature branch on github and committed to each branch before deciding which is the best one and only creating one branch.
What surprised you?
Nothing
Iteration 4 (Continuous Integration)
Is it easy to install? Does it work? Is there something in the code or documentation that could be improved?
Their code was easy to install and everything worked. The following list contains things that could be improved and things that we changed:
- Add .mp3 files as a ignored file in the git repo since they are getting generated in the folder
- The first vowel method seemed a bit big, and we suggested adding a new and cleaner method.
- We added cosmetic changes to the code meaning, blank spaces, line breaks, shorter code lines.
Reflections
What went well?
It was very easy to fork out a branch of someone else repository. We could then work on improvements as a team and when we are satisfied with the whole solution we made the pull request.
What would you like to improve or do differently?
in the code review of another team we made some cosmetic changes. That may not have been correct. The code was a little harder to read. Than our code.
What surprised you?
Nothing
What is your general opinion on the assignment: Was it worthwhile?
The group considers that the project was worth while since we got to experience to understand the importance of having pre-defined tests for a project.
Too easy or too difficult? Do you have suggestions for improvements? It was in between. Just right for what we needed to learn.
We liked that everything was well-defined and it was easy to allocate your time and ambition when it clearly stated how many hours we were expected to put in.
How much of the optional tasks did you do?
None.