Incremental Deliverable 1 Formal React Native Base Code Review Inspection - SeoulSKY/safe-zone-system GitHub Wiki

PR

• https://github.com/UniversityOfSaskatchewanCMPT371/term-project-fall-2021-team1/pull/30

Date

• October 1st

Length

• 30 minutes

Participants

• Jeremie(notetaker, reviewer)
• Jorgen(reviewer)
• Lucas(reader, reviewer)
• Zack(author)

Agenda

• Design Documents
  • Does this follow good coding standards?
  • Are there any problems with this pull request?
    • Could this break this system?
    • Could this break another system?
  • How could implementation be improved?
  • Is any code that is unclear what it does?
  • Does this satisfy all the requirements that it is supposed to?

Notes

• Anonymous function could be pulled out since when we add more routes, it will get quite long
• Could rename screens.ts to index.ts to allow it so simplify imports
• Use some typing in typescript