Incremental Deliverable 1 Formal CMS Base Code Review Inspection - SeoulSKY/safe-zone-system GitHub Wiki

PR

• https://github.com/UniversityOfSaskatchewanCMPT371/term-project-fall-2021-team1/pull/28

Date

• October 1st

Length

• 45 minutes

Participants

• Jeremie(notetaker, reviewer)
• Jorgen(reader, reviewer)
• Mark(author)
• Sahngwoo(reviewer)

Agenda

• Design Documents
  • Does this follow good coding standards?
  • Are there any problems with this pull request?
    • Could this break this system?
    • Could this break another system?
  • How could implementation be improved?
  • Is any code that is unclear what it does?
  • Does this satisfy all the requirements that it is supposed to?

Notes

• Rename from flask to cms since we're using multiple flask servers
• Rename nginx to reverse-proxy
• Update git ignore to not include the virtual env
• Follow the proper git format for commits