Triage Meeting February 09th, 2021 - Seneca-CDOT/telescope GitHub Wiki

Here: Professor Dave, Abdul, Anton, Chris, Ilya, Minh, Royce, Yuan

Here In Spirit: Mo, Tony, Pedro

Today's Agenda:

Pre-Meeting Notes:

Mohammed Ahmed 9:39 AM

Hi guys, I don't think I'll be able to make it to today's triage. I'm feeling quite unwell. Just to give you an update on things: My FRONTEND PR should be ready to merge. I'll have to recreate the npm7 fix pr since its way out of date. I got the remove paragraphs, and spaces to work. I'm finishing up on the braille function. The GitHub prototype is going well, I'm just testing out webhooks and how it works

Meeting Notes:

PRS:

PR #1674 - Fixed #1641: Moved ToggleThemeButton to Header and persist preferred theme value to localStorage:

  • Still in progress by Tony.

  • Awaiting changes.

  • Minh has some issues with how the PR is shaping up (read comments for more info on this.)

PR #1673 - Fixes: 1672 - [next] Investigate bugs related to Fonts.:

  • Anton askes: "Can we specify the global font weight in globals.css?" Will follow up with a comment.

PR #1667 - Porting Banner to Next [1616]:

  • Awaiting reviews from us.

PR #1657 - Triggering search via URL:

  • Awaiting on an update from DukeMahn.
  • Assigned Royce to review.

PR #1650 - [Documentation] Fixes #1632: Updated release documentation:

  • Anton still working on finishing this up.
    • Sage Wisdom: Don't be afraid to remove code.

PR #1636 - Proof of Concept for Image Microservice:

  • Continuing to be iterated on with Ray, nearing completion.

PR #1617 - Fixes #1534, added legacy-peer-deps option set to true:

  • Mo was having issues with a rebase, may be making a brand new PR shortly.

PR #1606 - Fixes #1576, Added FRONTEND env variable, updated routes/index.js:

  • Waiting for reviews from people.

PR #1530 - Slack integrations [ Siblings Check ]:

  • Status currently unknown, tagged Blocked, Left a comment asking for an update on the status of this PR.

PR #1524 - remove empty whitespace-only blocks from posts:

  • Mo said he's finishing up the braille function, will be ready for review shortly.

PR #1506 - Fix #1468: Port error page from Gatsby to Nextjs:

PR #1472 - Slack integrations [ Docker Events ]:

  • Waiting for a response from PR #1530 to proceed.

PR #1413 - Fix #1376: Showing BLANK with search terms return NO result:

  • Still working on this, waiting for update.

PR #1373 - Fixes #1370: Set picture in post as their natural size:

  • Yuan will discuss with Mo and decide when to work on this.

Issues:

Non 1.7 issues

Issue #1683 - [next] Image does not fit the banner size:

  • Added to 1.7
  • Assigned to Minh

Issue #1682 - Fix onClick reaction area in Next.js MobileHeader:

  • Added to 1.7
  • Assigned to Ilya

Issue #1680 - Fix Next.js Header height:

  • Added to 1.7

  • Assigned to Royce

Issue #1679 - Fix Next,js Header Telescope Icon Margins and size:

  • Added to 1.7
  • Assigned to Royce

1.7 Issues

Issue #1655 - Remove unncessary title and meta tags:

  • Waiting on issue 1651 to be finished before working on this (also waiting to touch base with Anton.)

Issue #1651 - [next] Style the newly added About page:

  • Waiting on Layout discussion with Anton, Ilya, Royce, and Chris for update.
  • Will be in before 1.7

Issue #1663 - Fix inconsistent styling of Login tab on Next frontend:

  • Added to 1.7
  • Assigned to Anton and Ilya.

Issue #1647 - Create a config file for Dependabot:

  • Anton and Yuan will have a meeting to discuss the status of this.

Issue #1592 - Update deps from 1.5 release:

  • Yuan is still working on this.
    • Yuan may wait on Dependabot before working on this.

Issue #1588 - Update highlight.js:

Issue #1557 - Add guide for working with TS, MUI, next.js:

  • Suggested Fix: This issue can be more organized into a large document explaining NextJS and other technologies we use in Telescope 2.0 for contributors who want to help out but have never worked with tech like NextJS or TS or MUI, etc.

Issue #1554 - Directly export all components in next.js code as Component.tsx files:

Issue #1553 - Remove all uses of React.FC in our TypeScript code:

Issue #1490 - About Page - Fix content alignment.:

  • Closed by Chris as it's not needed anymore.

Issue #1415 - "No search results" message shows up before searching anything:

  • Being worked on by Royce and Minh.

Issue #1412 - Deal with inline images being streched (aka reduce the size of Tony):

  • Will be worked on by Royce and Mo and Yuan.

Issue #1252 - Reduce log spam:

  • Will be worked on by Yuan, Mo, and Dave.

Issue 1642 Discussion:

Issue #1642 - Add a database for user and feed info, drop planet feed list:

  • The database will be a microservice used to replace the Planet Feed List:
    • The current plan is to keep two Firebase collections: One for legacy users (all users in the feed list), and one for new users.
      • When an old user logs in, her / his account will be migrated to the new user database.
    • Users will be allowed to alter their display name at will, but Telescope will, by default, use the Full Name that Seneca's SAML SSO returns.
    • This database does not need a frontend at present time.
    • The user object will store the following: FirstName, LastName, DisplayName, Feeds(array), GitHub Username, GitHubAvatarURL, isAdmin, isDisabled

Leading next week's meeting: Minh

Taking notes next week: Yuan