Triage Meeting 1.9.5 Notes (6th of April, 2021) - Seneca-CDOT/telescope GitHub Wiki

David's Intro

  1. We've got a new landing page - thanks to Pedro and others involved for hard work

  2. Reviews: we've got 15 open PRs and some of them were open for weeks. It is frustrating to do work because only a few people do reviews. Advice:

    • Stop mentioning a lot of people in the issue as reviewers - this is not helpful.
    • Please do reviews - dedicate some time to help people land their work so frustration can be avoided
    • There is going to be a lot of stuff to be landed closer to the end of the term - we don't want to leave everything till the end and reviews will be needed to avoid regression.
    • We need to clear 15 reviews that we have and keep them close to 0 at all times.
  3. Telescope is a great opportunity for you to learn and explore areas, that will be useful in your future career.

  4. We've got new contributors! Please help them with their work by doing reviews and responding on Slack if needed.

Comments

  • Abdul: we should add testing instructions to PRs
  • David: to help people land tickets - set up a group session to walk through the PR with a person who was working on it
  • Chris: Group sessions of 2-5 people are great for reviews.

The challenge of the week - dedicate time for reviews so we can successfully land 2.0.

The Triage

PRs covered

  • 2085 - from Dependabot, nothing to discuss.
  • 2082 - another colour should be considered. Yuan will continue working on it.
  • 2081 - needs reviews.
  • 2080 - reviewers and testers needed. To see the perfect example of what should be achieved go to Tesla.com.
  • 2076 - waiting for reviews and help. TypeScripts magicians needed.
  • 2066 - Needs testing and reviews. Good to merge if no problems found.
  • 2058 - David is working on it, not reviewable yet. David is working on tests for this rn.
  • 2035 - needs rebasing before reviews. Anton will help with the rebase.
  • 2033 - Ask Tony about what is needed. Needs reviewers.
  • 2012 - blocked by search service, can be reviewed after search service lands.
  • 2008 - rebase and merge.
  • 2005 - rebase and reviews needed.
  • 1828 - Waiting for updates from c3ho.
  • 1802 - Ilya is working on it, should be pushed soon.

19.5 release Issues

  • 2083 - will be in and ready for reviews before Friday. A discussion on this will take place.
  • 2079 - will be closed by PR 2081.
  • 2051 - Yuan is working on it
  • 2047 - will be done by Yuan.
  • 2042 - will be closed by PR #2080
  • 2041 - Yuan and Huy will hop on a call for a discussion about it.
  • 2039 - the PR will be up later today.
  • 2028 - closed due to a planned change of the search bar.
  • 2000 - will be closed
  • 1994 - It Will be started after the Pallete changed.
  • 1997 - discussion about using names of the author took place. Quotes needed
  • 1929 - blocked by auth and user services. should be unblocked by end of the week.
  • 1809 - Ilya will take a look.
  • 1801 - waiting for HyperTHD for the comments
  • 1693 - no comments
  • 1643 - delayed until front-page lands. Moved to 2.0
  • 1611 - Mo needs help on this. Moved to 2.0
  • 667 - no comments
  • 570 - taken out of 1.9.5
  • 290 - left for 3.0

Next week leaders:

Anton - Leader

Abdul - Notes