Guidelines for testing new code changes - Satellite-im/Core-PWA GitHub Wiki
Every time a PR is added, our team performs code review and testing on all our Pull Requests suggesting code changes. This allows preventing bugs from reaching our main branch 🔨
Testing a Pull Request
Requirements:
- You need to have the local setup ready and running. You can find instructions related to that on our README.md.
With that done, we can now:
- Go to https://github.com/Satellite-im/Core-PWA/pulls
- Checkout the branch related to the PR such as
git pull branch-name-here
yarn
yarn dev
- open localhost
- test if the changes are doing what is described in the PR description
- make sure the same issue is not already in the dev branch, we shouldn't report unrelated bugs to the code changes on the PR
- report any problems in the PR comments with the following structure:
- flow: (which steps are you executing in order to experience the issue such as
1. login, 2. clicked on continue button, and so on)
- issue that you are experiencing: (description of the bug)
- expected behavior: (description of the behavior you were expecting)
- any extra data such as screenshots/videos for the developers to better reproduce the issue
- browser/device used
example