DevNotes_4Nov2025 - SasView/sasview GitHub Wiki
General Updates
- The contributor camp begins in seven days - Nov 11th.
- The US gov remains in a shutdown status
- This has impacted the 6.1.1 cleanup (see below)
- This will now likely impact the contributor camp - 4 US participants.
6.1.1 Release Cleanup Status
- As agreed last meeting, the 6.1.1 release branch has been merged into main.
6.1.2 Release
- Last meeting we agreed that Paul Sharp will create a 6.1.2 branch off of main Friday Nov 7 (just before the contributor camp)
- However, we have since found issues with the 6.1.1 bug fix release - see #3648, #3658, #3660, #3663.
- Paul Butler has proposed we add these fixes to the documentation and plugins ONLY to a quick 6.1.2 release (potentially to go out this week), and then create a 6.1.3 release branch for other bug fixes on Friday Nov 7.
- Thoughts on this? - Agreement that a small 6.1.2 release is a good idea, thoughts that we should consider after the contributor camp whether a 6.1.3 release is necessary or whether we should go to a later 6.2 release.
Pull Requests
-
Reminder: following the changes in sasview #3596, including the removal of
run.py, SasView is launched by either runningpython -m sasorsasviewin a terminal. Following sasview #3656, you can also run the file__main__.pyfrom a IDE. -
Discussed at the last meeting
-
Merged since last meeting
- sasmodels #652 - reduce debug output in doc build
- sasview #3634 - Replace direct AUSAXS library integration with the pyAUSAXS wrapper
- sasview #3596 - move qt gui build to cli.py and remove run.py
- sasview #3504 - Various fixes to try to get sasview sphinx docs to build cleanly
- sasview #3642 - Reduce duplicate building on CI (plus other CI improvements)
- sasview #3587 - Corfunc fix
- sasmodels #668 - Update docstrings for sasmodels data functions
- sasmodels #680 - Update Python versions in test matrix
-
Outstanding from the last meeting
- sasview #3534 - Fetching of the license file from relative path - disagreement over what to do - leave for now
- sasdata #47 - Finishing the manipulations.py Rewrite - rebased, codescene issues and tests fail - consider further at contributor camp
- sasdata #62 - Interpolations for data operations - draft, still to be decided whether to merge or close - consider further at contributor camp
- sasmodels #673 - Fix limits on angles and angular dispersity - @dehoni to review
- sasview #3601 - Qwedge - @butlerpd to review
- sasview #3544 - shape2sas plugin models - @butlerpd to review
- sasview #3602 - Dependabot: Include all action updates in one PR - discussion required - leave for now
- sasmodels #679 - Cache figures between CI builds to speed up runs - @rozyczko to review
- sasmodels #677 - Fix RepeatedKernelRetrieval error in OpenCL - review required
- sasmodels #658 - Simple adaptive integration - review required (large PR so unlikely to merge before contributor camp)
-
-
Created since last meeting
-
Merged
- sasmodels #681 - Updates location of plugin models in docs
- sasdata #166 - Upgrade python version to 3.12 and fix linting errors
- sasview #3642 - Reduce duplicate building on CI (plus other CI improvements)
- sasview #3649 - Upgrades python to version 3.12
- sasview #3650 - Fixes bug in nightly build
- sasview #3651 - Fixes second bug in nightly build
- sasview #3656 - Removes relative import in main.py
- sasview #3659 - Updates import statements for routine "find_plugins_dir"
- sasview #3661 - Include API docs from sasmodels in sasview sphinx output
- sasview #3665 - Updates location of plugin models in docs
-
Outstanding
- sasview #3652 - Use Python 3.13 for next release - discussion required - we want to support older python versions, will consider further when we get to 6.2 release
- sasview #3653 - Rework CI variables - @rozyczko to review
- sasview #3657 - Modifies installation documentation - approved, @DrPaulSharp to merge
- sasview #3666 - Make ruff more verbose about what it doesn't like - @DrPaulSharp to review
- sasview #3667 - Factor out documentation-locating code to be portable - @DrPaulSharp to review
- sasview #3678 - Remove uses (and traces!) of pkg_resources - review required
-
Refactoring Project
- I have merged the Quantities work from the refactoring project into the main branch of sasdata sasdata #167
- I will work on other branches this week, likely focussing on trends, operations on datasets, and loading and saving data.
- The refactoring roadmap is available here
- Plotting refactor branch has been rebased, are we able to review and merge?
- We will consider this further at the contributor camp
CodeScene and Ruff
- Ruff is setup on SasView, SasData and SasModels. Codescene is only enabled for SasData.
- Decision: Punt on hooking up codescence to sasmodels and sasview till after the camp. YES.
- The original agreement was to activate CodeScene at the lowest level for sasmodels and sasview, as it has been for sasdata, once 6.1.1 was released.
- Decision: Punt on hooking up codescence to sasmodels and sasview till after the camp. YES.
- I have found codescene quite inflexible when working on merging the refactoring project into main - we should review the requirements at a later date, and before applying codescene to the other repositories.
- Unlike ruff which will automatically change things on the CI, codescene demands unspecific changes and fails the CI.
- Agreement that codescene is a useful developer tool, but we do not want to present a barrier to an everyday developer
- We may be able to resolve problems through adjusting settings.
Contributor Camp Planning
- Update from Nov 3rd BIOSAS meeting: https://github.com/SasView/sasview/wiki/BioSAS-meetings (Wojtek)
Help Desk Staffing needs
- Dirk is primary and Steve is secondary for November.
- We have holes in the schedule from December onwards. Anybody willing and able?
AOB?