2021 03 18 Full Team Meeting - SE701Group2/daily-focus GitHub Wiki

Present: Everyone except...

Absent: Zichun Lin, Henderikus Parekowhai

Agenda

  • Standup: everybody, what are you working on, how far from getting a PR up, what is blocking you (is there someone that you need to talk to)
  • At the same time: say if you have done a review or not. Will make a list so we can ensure everyone has a chance to do a review
  • Testing. We need unit tests with all PRs. - Di Kun Enzyme compatibility?
  • Styling consistency and introducing a common folder? (Steven?)
  • File structure changes needs? Steven
  • Table of contributions
  • Presentation plan? (or have another team meeting before Monday?)
  • Steven - storage for the information about which widgets are on/off

Minutes

Standup

  • Denise - merged in PR, more documentation for frontend. Pair programming with Kenneth, helping Gang with design. Code review done.
  • Charlie - widget container. Completed but no PR because tests needed - need to think about how to do this. Code review done?
  • Daniel & Michael - calendar functionality is nearly there. Styling not done. Reviews done.
  • Di Kun - roadblock on integrating Enzyme for snapshot tests with React - Enzyme only works with React 16 and earlier and our project is on 17.0.1.
  • Gang - Need to talk to Tommy to plan where to put the button on the TODO list page. He has finished the button and the modal to grow trees. Need to have Tommy finish his component.
  • Jenna - (sorry wasn’t thorough Jenna if you want to fill this out). Needs backend team to get their end points done
  • Jigao - weather component currently gets non-real-time weather data?? Still need to get upcoming weather details.
  • Joel - POST endpoint for to-do list - hasn’t started yet but aims to do it by the end of today.
  • Jonathan - GET endpoint for to-do list - 90%? Done, just needs to add proper data structure for object.
  • Kenneth - Date/time component is in progress, working with Denise tomorrow to get it done.
  • Raymond - helping others write their endpoints, managing database structure.
  • Rui - DELETE endpoint for to-do list. Still workin.
  • Sannan - header. Needs to be reviewed by one other person.
  • Steven - modal for selecting widgets is functionally + visually done but needs info on how data is being stored in frontend/backend.
  • Tommy - to-do list is functionally done, cleaning up some styling.
  • Vishnu - PUT endpoint for to-do list. Waiting for auth to be done? Don’t need to wait to submit PR.

Testing, testing, testing

  • As mentioned in standup - issue with Enzyme compatibility. Enzyme is an easy way to get testing going, so may need to roll back to React 16. Seems like it’s generally the best idea to try that, see if it works, then write an example snapshot test for everyone to model off. Need at least ONE snapshot test per PR, I think.
  • Backend has no testing framework set up. Need to investigate this urgently - will discuss after meeting.

Frontend styling

  • Probably not a priority atm until functionality is in a better place

Deadline for finishing components - PR up by Saturday. Code reviews done ON Sunday.

Table of contributions

  • Gonna set it up on the GitHub wiki shortly
  • Everyone needs to document their own contributions!

Demo

  • Need to prepare material on Sunday - allocate subset of people to take charge of this
  • Steven, Di Kun, Jenna, Raymond

No Code Review Yet List

  • Di Kun
  • Gang
  • Joel
  • (Jigao not sure)
  • Kenneth
  • Steven

Raymond questions - pass credentials to the backend, backend returns an API key, then we use that API key with every subsequent request.

Action Points

  • Frontend meeting about styling, structure and component reuse
  • Backend meeting with Denise about what they need wrt API token
  • Deadline Saturday 5pm, with whatever styling and functionality you have
  • Testing!! Come up with a plan to sort testing (enzyme frontend, backend needs to have a meeting)