PR Review Checklist - SAP/fundamental-styles GitHub Wiki

Check if the code matches 100% the design specs

For the component being refactored make sure all occurrences of fd-color, fd-space, fd-anything are removed

All values in PX are changed to REM

Mixins are used for repeatable code (fd-rtl, fd-ellipsis, fd-flex, fd-selected, fd-focus, ect.)

BEM is applied correctly

Text elements follow the truncation rules

Check all states of the element - hover, active, selected, selected hover, pressed, etc.

Responsiveness rules - the component has modifier classes for all breakpoints

Compact/Cosy/Tablet design

Focus rules

A11y support - keyboard support, screenreader support, proper ARIA attributes, etc.

RTL support

Playground - normalize, un-normalize, theming (Reset is applied for the elements)

Tests have been updated

Storybook has been created/updated

In case of composite component check if the update doesn't break the other components

Check if current components can be reused, instead of having new code.

Variables are used, if some value is used more than twice.

Check if some markups are redundant

IE11

Breaking Changes wiki has been updated in case of breaking changes.