Contributing and working with Fundamental styles - SAP/fundamental-styles GitHub Wiki

• Download, Installation and Project Dependencies - link

• Fundamental-styles GitHub issues - link

Fiori 3 refactoring related issues have Fiori 3 refactoring label. Don't forget to assign the issue to yourself once you start working on it to avoid multiple people working on the same issue.

• Naming of the branches and the PRs - link

• Running the documentation - link

• CSS variables in the project coming from @sap-theming: node_modules/@sap-theming/theming-base-content/content/Base/baseLib/sap_fiori_3/css_variables.css

• “darken” and “lighten” functions do not work with css variables!!! Use the base color and create an issue

• Running the project Playground

You need Docker installed and running!

• Test the theme, normalize, un-normalize, and RTL in the playground

For theming you might want to add colors to the “test/resources/theme-ugly.css” file

• Visual testing

• Runing the tests

• Updating the tests

!!!!! npm run update may update more tests than necessary. Commit only the tests that concern your changes !!!!!

• Update the Breaking Changes

• Open Pull Request

Follow the template, provide Before and After screenshots, reference to the relevant issue number using “closes #issueNumber”

• Add the fundamental-team as reviewers: InnaAtanasova, mikerodonnell89, JKMarkowski, jbadan, stefanoScalzo