TA Feedback Mar 3 - RostarSynergistics/ShinyExpenseTracker GitHub Wiki

Code Base of Prototype

• Lots of FIXME comments everywhere. Some no longer apply. Better to use tickets in general, but some fixme stuff is ok. Make sure these are all fixed by the end of project part 4
• Storing data in shared preferences is a bit weird
• public class ExpenseClaim implements IModel<IView<ExpenseClaim>> This is weird.. ExpenseClaim implements IModel of IView of ExpenseClaim. Do you even need IModel? Does anything even use IModel directly?
• String currency is bad

Making good progress!!

Code Documentation

Where is this? There seems to be none.

Test Cases

Where are they? I see lots of commented out tests, but that's it.. I take it you haven't been doing TDD.

OOD

Mostly good, but the IModel/IView thing is weird.