OOA

misc.

• where is the dia file? I could only find the svg
• a bit cluttered, I would like you to try re-arranging things a bit to reduce clutter

good

• Obvious MVC (IModel/IView/*Controller)
• Model classes obvious
• Data classes present
• good use of aggregation/composition
• generally very clear, I understand how your app will work

what is holding you back from excellence

• No binding info on generics

• Not very clear what data classes do...

• diagram a bit messy

• passive relationships are confusing, instead of saying "ExpenseClaim is viewed by ExpenseListTab," say "ExpenseListTab displays ExpenseClaims"

• Why is ListExpenseClaimActivity not an IView?

• No reference to saving things offline

• How do IModels implement {add|delete}View(IView) without aggregating views?

• relationship roles should be on either end of the arrow.

          1                            0..*
   [ Bus ]<>------------------------------[ Person ]
                                       passenger
  

Feedback

misc.

• the wiki sidebar looks nice

good

• split mockup out of storyboard. This looks very nice!

what is holding you back from excellence

• looks like you did not do anything with your tests
• your commit messages are not very informative, which means I may miss something that you did to address feedback