Requirements Specification

misc

• some tests are a bit confusing

bad

• Some use cases have incorrect/unrelated data. Eg. #20 includes exceptions for a different use case

• Because we don't require that these tests pass, they can be fanciful as long as they tested the right thing. Eg. For OfflineTests.testDataCached():

   ClaimSaver saver = new ClaimSaver();
   saver.setInternetEnabled(false);
   Claim c = new Claim();
   assertTrue("claim should save locally", saver.save(c) == ClaimSaver.LOCAL);
  

• some tests do not reference use cases

• A couple of use cases are not tested (mostly view _). Not a huge deal, but remember that you could just make up code to illustrate the test.

good

• numbered use cases (thanks github)
• use cases cover all user stories
• tests generally look very nice!

User Interface Mockups and Storyboard

misc

• the app looks easy to use
• this gigantic svg is very hard to navigate

bad

• should have a mockup and a storyboard (separately). From the assignment: "Diagram the layout of your main user interface and major dialogs, with comments describing the important elements. Also, provide one storyboard sequence for a non-trivial but coherent scenario of using your application" I will assume that the storyboard is also serving as a mockup and that it contains all activities from the app.
• storyboard needs more comments
• some things missing from use cases: eg. filter by tag

good

• Storyboard is nice and readable

Release Planning

good

• good use of the issue tracker!
• good synergy between requirements specification and release planning
• time estimates
• seems achievable

Glossary

misc

• you dont' really need to list all of the activities

bad

• would have liked some informational links as well

good

• thorough, easy to read glossary
• lots of links!