March 24 Meeting - RostarSynergistics/ShinyExpenseTracker GitHub Wiki

  • Elastic search has features for geolocation
  • Get a library to do geolocation if you're going to do it yourself
    • geolocation is a big waste of time anyway.

Ramish

Did:

  • no more time traveling claims
  • Removed miscelaneous ui issues (double tapping date picker)
  • Congratulated Tristan for fixing the thing (after he walked over and bragged for several minutes)

To Do

  • Whatever's needed/decided after this meeting

Blockers

  • None

Adam

Did

  • persistence things with expense items
  • tests proved that code was working fine, but was never ever called.
  • Was never actually calling add or remove expense item list things

To do

  • write tests that fail and fix them
  • FIX THIS THING :D

Blockers:

  • none

Alex

Did

  • Almost finished marking part 4
  • gathered information, but haven't put in grade or emailed
    • general reaction good

To Do

  • Post grades later (after marking others)
  • Talk about feedback

Blockers

  • None

Sarah

Did

  • Removed all unused "Setting" menu items
  • Pulled Ramish's pull request

To Do

  • What needs to be done

Blockers

  • None

Oleg

Did

  • Updated all of receipt issues

To Do

  • What gets decided later

Blockers

  • None

Tristan

Did

  • Fixed the library issues on the lab machines

To Do

  • Finish writing that thing for the expense list view details that were missing in the list view
  • You know, that thing.

Blockers

  • No blockers

Rajan

Did

  • Nothing

To Do

  • Connect tags to claims

Blockers

  • None

Feedback

Indexes

  • use UUIDs and checking the object exactly instead of positions in the controller

Tests

  • Mocks can add sanity checks
  • Mocking framework (for reference)

MVCs

  • Some controllers not used; treated as models
    • "Activity get controller, Activity get model. Ignore controller"
  • Updating?

Better validation?

  • Models in charge of their own validation.
  • Controllers in charge of model validation
  • Extract a dialog class for validation messages

Addressing Feedback

  • Include some indication that feedback has been addressed
    • Tag @aewilson-ua in issues, include comments(?), etc.

Mainly: Good refactoring, missing features, surprise requirements

Make elastic search do everything. Everything. Make it do the whole project if it can.

BIG FOUR

ElasticSearch

  • Start ASAP
  • Ramish and Adam. (Ramish has experience)

Offline/ElasticSearch Synergy

  • UUID generation (universally unique identifier).

Syncing

  • EventHandler - Android can tell you if you have network
  • How to tell if something is changed?
    • Versioning? <-- Built into ElasticSearch (Probably the easiest way)
      • ElasticSearch will reject old versions (must enable it)
      • Push all to ElasticSearch (not to origin/master), then pull on reconnect
      • Make sure you're not overwriting something if there's no change
        • If someone else makes a change too it may reject their changes
        • ES checks version number (don't change version number if there are no changes)

Approval

  • We have to do it.

Geolocation Stuff

  • Let elastic search do it

Next Tuesday

Gang of 4

Related Issues:

  • Create a master issue that references the smaller issues (Put the IDs in the master for all smaller issue)
  • Mark that master issue as what you're working on
  • Marks smaller issue as Blocked.
  • You still shouldn't have more than 1 issue in development