Step 11 - Riverside-Software/pugchallenge2019 GitHub Wiki
Pull requests (part 2)
Your job as a code reviewer is to verify that code does what it is expected to do, that it is automatically tested, and that it matches the coding standards.
Only for the code reviewer
- Open the pull request that has been assigned to you. An email should have been sent, but if you don't have access to your emails, you'll find it here. The main view of the pull request presents the discussion and if checks were successful or not. The first thing a code reviewer wants to know is if the build is successful:
- Then the code reviewer has to review the code, and can comment on any section:
- Back on the first tab, click on the "Details" link (next to the Jenkins check). The Jenkins build page is opened:
- Test results can be seen by clicking on the "Test Result" link; the code reviewer should never validate a pull request which has unit test failures.
- Code analysis is also executed in the pipeline, and the outcome can also be seen in Jenkins:
- Click on the OK button next to "DataDigger" ; the branch analysis page is opened:
- Navigate through the code
Back to the developer
- Push two separate commits to the central repository, and wait for Jenkins to trigger the build
- First commit with invalid code (which doesn't compile) : this has to trigger a build failure in Jenkins
- Second commit with a quality issue (such as a dot comment) : this has to trigger a quality gate failure in Jenkins
🚀🚀🚀 Jump to Step 12 !!! 🚀🚀🚀