10 26 2020 Tech Team Report - QualitativeDataRepository/TechnicalTeam GitHub Wiki

10-26-2020

Logged Tasks

                            Date             Task Hours (Main) Hours (EOLS) Hours (PII)
19-Oct-2020 Report, meeting, debug PR test failures 1 3
20-Oct-2020 Investigate stage update 1
21-Oct-2020 Deploy DV 5.1.1 and Drupal to stage, debug config issues 4
22-Oct-2020 Update login_history to add mail opt in, respond to metrics PR feedback, update file replace PR to handle all cases 4
23-Oct-2020 Start merging #7337 1

Summary

Drupal

  • Deployed latest to stage (with mail opt-in, without search updates), configured login_history report to include the mail opt-in status (can be used to get a list of opted-in emails).

Dataverse

  • Fixed Payara install jvm-options on stage and deployed v5.1.1-qdr to stage. Tested bucket access to stage and prod(read-only).
  • Debugged various issues with the 'replace-file-in-draft' PR(#7336). My original solution appears to recreate a bug for another use case. I resolved this issue and, in the process, discovered several related issues with tests (when they run, whether they work, whether they have timing-dependent outcomes) and code (both code and tests producing/expecting an OK HTTP response for failure cases). (I ended up resolving these and cleaning up/documenting how the complex UpdateDatasetVersionCommand works on GDCC time.) At the end of the week, I started merging these updates back into the 5.1.1.-qdr branch.
  • Responded to various comments from pdurbin on the new-metrics and dataverse-metrics PRs. Some of his questions were about backwards-compatibility (new code works with old instances, old metrics installs need a minor tweak to work with 5.1+ servers) and the choice of CSV instead of TSV (biggest concern was that I had switched dataverse code from TSV to CSV, but I hadn't - the old dataverse-metrics creates TSV internally with python by reading json outputs from Dataverse). Awaiting any further comments/requests for changes from IQSS.

Discussion

  • Review stage payara update process

Plans

  • Finish #12 search changes
  • Fix ul/li styling in dataset description reported by Robert
  • Finish merging file-replace updates
  • Issue queue

Still TBD:

  • Drupal 9